wifi: rtw89: debug: add debugfs entry to disable dynamic mechanism

A dynamic mechanism is usually an algorithm to adjust registers to adapt
to different environment every two seconds. In field, it could get
unexpected result, so we need to stop it and adjust registers manually, and
then fine tune the algorithm.

To stop mechanisms to assist debugging, add a debugfs entry shown as

  Disabled DM: 0x1
  [0] DYNAMIC_EDCCA: X

Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20231122060458.30878-4-pkshih@realtek.com

diff --git a/drivers/net/wireless/realtek/rtw89/core.h b/drivers/net/wireless/realtek/rtw89/core.h
index 00aa9e96541c57263a7987c4f3c65b517ac7953b..c9f054c0f6fb2be44f491693226f220928558bb4 100644 (file)
--- a/drivers/net/wireless/realtek/rtw89/core.h
+++ b/drivers/net/wireless/realtek/rtw89/core.h
@@ -4033,6 +4033,10 @@ struct rtw89_edcca_bak {
        u8 th_old;
 };
 
+enum rtw89_dm_type {
+       RTW89_DM_DYNAMIC_EDCCA,
+};
+
 struct rtw89_hal {
        u32 rx_fltr;
        u8 cv;
@@ -4058,6 +4062,7 @@ struct rtw89_hal {
        enum rtw89_entity_mode entity_mode;
 
        struct rtw89_edcca_bak edcca_bak;
+       u32 disabled_dm_bitmap; /* bitmap of enum rtw89_dm_type */
 };
 
 #define RTW89_MAX_MAC_ID_NUM 128

diff --git a/drivers/net/wireless/realtek/rtw89/debug.c b/drivers/net/wireless/realtek/rtw89/debug.c
index a3f795d240ea5e90b310a11dd9ed1c117458adbb..f914c0750576cf4d2f0d36a23a62a350dc3261ee 100644 (file)
--- a/drivers/net/wireless/realtek/rtw89/debug.c
+++ b/drivers/net/wireless/realtek/rtw89/debug.c
@@ -3770,6 +3770,58 @@ static int rtw89_debug_priv_stations_get(struct seq_file *m, void *v)
        return 0;
 }
 
+#define DM_INFO(type) {RTW89_DM_ ## type, #type}
+
+static const struct rtw89_disabled_dm_info {
+       enum rtw89_dm_type type;
+       const char *name;
+} rtw89_disabled_dm_infos[] = {
+       DM_INFO(DYNAMIC_EDCCA),
+};
+
+static int
+rtw89_debug_priv_disable_dm_get(struct seq_file *m, void *v)
+{
+       struct rtw89_debugfs_priv *debugfs_priv = m->private;
+       struct rtw89_dev *rtwdev = debugfs_priv->rtwdev;
+       const struct rtw89_disabled_dm_info *info;
+       struct rtw89_hal *hal = &rtwdev->hal;
+       u32 disabled;
+       int i;
+
+       seq_printf(m, "Disabled DM: 0x%x\n", hal->disabled_dm_bitmap);
+
+       for (i = 0; i < ARRAY_SIZE(rtw89_disabled_dm_infos); i++) {
+               info = &rtw89_disabled_dm_infos[i];
+               disabled = BIT(info->type) & hal->disabled_dm_bitmap;
+
+               seq_printf(m, "[%d] %s: %c\n", info->type, info->name,
+                          disabled ? 'X' : 'O');
+       }
+
+       return 0;
+}
+
+static ssize_t
+rtw89_debug_priv_disable_dm_set(struct file *filp, const char __user *user_buf,
+                               size_t count, loff_t *loff)
+{
+       struct seq_file *m = (struct seq_file *)filp->private_data;
+       struct rtw89_debugfs_priv *debugfs_priv = m->private;
+       struct rtw89_dev *rtwdev = debugfs_priv->rtwdev;
+       struct rtw89_hal *hal = &rtwdev->hal;
+       u32 conf;
+       int ret;
+
+       ret = kstrtou32_from_user(user_buf, count, 0, &conf);
+       if (ret)
+               return -EINVAL;
+
+       hal->disabled_dm_bitmap = conf;
+
+       return count;
+}
+
 static struct rtw89_debugfs_priv rtw89_debug_priv_read_reg = {
        .cb_read = rtw89_debug_priv_read_reg_get,
        .cb_write = rtw89_debug_priv_read_reg_select,
@@ -3845,6 +3897,11 @@ static struct rtw89_debugfs_priv rtw89_debug_priv_stations = {
        .cb_read = rtw89_debug_priv_stations_get,
 };
 
+static struct rtw89_debugfs_priv rtw89_debug_priv_disable_dm = {
+       .cb_read = rtw89_debug_priv_disable_dm_get,
+       .cb_write = rtw89_debug_priv_disable_dm_set,
+};
+
 #define rtw89_debugfs_add(name, mode, fopname, parent)                         \
        do {                                                                    \
                rtw89_debug_priv_ ##name.rtwdev = rtwdev;                       \
@@ -3885,6 +3942,7 @@ void rtw89_debugfs_init(struct rtw89_dev *rtwdev)
        rtw89_debugfs_add_w(fw_log_manual);
        rtw89_debugfs_add_r(phy_info);
        rtw89_debugfs_add_r(stations);
+       rtw89_debugfs_add_rw(disable_dm);
 }
 #endif
 

diff --git a/drivers/net/wireless/realtek/rtw89/phy.c b/drivers/net/wireless/realtek/rtw89/phy.c
index 3d5bd888218e66e3cf0016c891f88c364d87469f..bfb1d8cfc53113e91c005be78307998c6b58503e 100644 (file)
--- a/drivers/net/wireless/realtek/rtw89/phy.c
+++ b/drivers/net/wireless/realtek/rtw89/phy.c
@@ -5091,6 +5091,11 @@ void rtw89_phy_edcca_thre_calc(struct rtw89_dev *rtwdev)
 
 void rtw89_phy_edcca_track(struct rtw89_dev *rtwdev)
 {
+       struct rtw89_hal *hal = &rtwdev->hal;
+
+       if (hal->disabled_dm_bitmap & BIT(RTW89_DM_DYNAMIC_EDCCA))
+               return;
+
        rtw89_phy_edcca_thre_calc(rtwdev);
        rtw89_phy_edcca_log(rtwdev);
 }