backlight: mp3309c: Utilise temporary variable for struct device

We have a temporary variable to keep pointer to struct device.
Utilise it where it makes sense.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Tested-by: Flavio Suligoi <f.suligoi@asem.it>
Link: https://lore.kernel.org/r/20240208184313.2224579-4-andriy.shevchenko@linux.intel.com
Signed-off-by: Lee Jones <lee@kernel.org>

diff --git a/drivers/video/backlight/mp3309c.c b/drivers/video/backlight/mp3309c.c
index 426e9f2356ad08908d897f64131acce97b7ad5b0..708c053d492c052d838d002ab01d294d41748c87 100644 (file)
--- a/drivers/video/backlight/mp3309c.c
+++ b/drivers/video/backlight/mp3309c.c
@@ -222,10 +222,9 @@ static int mp3309c_parse_fwnode(struct mp3309c_chip *chip,
         */
        pdata->dimming_mode = DIMMING_ANALOG_I2C;
        if (device_property_present(dev, "pwms")) {
-               chip->pwmd = devm_pwm_get(chip->dev, NULL);
+               chip->pwmd = devm_pwm_get(dev, NULL);
                if (IS_ERR(chip->pwmd))
-                       return dev_err_probe(chip->dev, PTR_ERR(chip->pwmd),
-                                            "error getting pwm data\n");
+                       return dev_err_probe(dev, PTR_ERR(chip->pwmd), "error getting pwm data\n");
                pdata->dimming_mode = DIMMING_PWM;
                pwm_apply_args(chip->pwmd);
        }
@@ -243,11 +242,9 @@ static int mp3309c_parse_fwnode(struct mp3309c_chip *chip,
                num_levels = ANALOG_I2C_NUM_LEVELS;
 
                /* Enable GPIO used in I2C dimming mode only */
-               chip->enable_gpio = devm_gpiod_get(chip->dev, "enable",
-                                                  GPIOD_OUT_HIGH);
+               chip->enable_gpio = devm_gpiod_get(dev, "enable", GPIOD_OUT_HIGH);
                if (IS_ERR(chip->enable_gpio))
-                       return dev_err_probe(chip->dev,
-                                            PTR_ERR(chip->enable_gpio),
+                       return dev_err_probe(dev, PTR_ERR(chip->enable_gpio),
                                             "error getting enable gpio\n");
        } else {
                /*
@@ -265,8 +262,7 @@ static int mp3309c_parse_fwnode(struct mp3309c_chip *chip,
        }
 
        /* Fill brightness levels array */
-       pdata->levels = devm_kcalloc(chip->dev, num_levels,
-                                    sizeof(*pdata->levels), GFP_KERNEL);
+       pdata->levels = devm_kcalloc(dev, num_levels, sizeof(*pdata->levels), GFP_KERNEL);
        if (!pdata->levels)
                return -ENOMEM;
        if (device_property_present(dev, "brightness-levels")) {
@@ -336,21 +332,21 @@ static int mp3309c_probe(struct i2c_client *client)
        if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C))
                return dev_err_probe(dev, -EOPNOTSUPP, "failed to check i2c functionality\n");
 
-       chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL);
+       chip = devm_kzalloc(dev, sizeof(*chip), GFP_KERNEL);
        if (!chip)
                return -ENOMEM;
 
-       chip->dev = &client->dev;
+       chip->dev = dev;
 
        chip->regmap = devm_regmap_init_i2c(client, &mp3309c_regmap);
        if (IS_ERR(chip->regmap))
-               return dev_err_probe(&client->dev, PTR_ERR(chip->regmap),
+               return dev_err_probe(dev, PTR_ERR(chip->regmap),
                                     "failed to allocate register map\n");
 
        i2c_set_clientdata(client, chip);
 
        if (!pdata) {
-               pdata = devm_kzalloc(chip->dev, sizeof(*pdata), GFP_KERNEL);
+               pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);
                if (!pdata)
                        return -ENOMEM;
 
@@ -367,11 +363,10 @@ static int mp3309c_probe(struct i2c_client *client)
        props.type = BACKLIGHT_RAW;
        props.power = FB_BLANK_UNBLANK;
        props.fb_blank = FB_BLANK_UNBLANK;
-       chip->bl = devm_backlight_device_register(chip->dev, "mp3309c",
-                                                 chip->dev, chip,
+       chip->bl = devm_backlight_device_register(dev, "mp3309c", dev, chip,
                                                  &mp3309c_bl_ops, &props);
        if (IS_ERR(chip->bl))
-               return dev_err_probe(chip->dev, PTR_ERR(chip->bl),
+               return dev_err_probe(dev, PTR_ERR(chip->bl),
                                     "error registering backlight device\n");
 
        /* In PWM dimming mode, enable pwm device */
@@ -383,8 +378,7 @@ static int mp3309c_probe(struct i2c_client *client)
                pwmstate.enabled = true;
                ret = pwm_apply_might_sleep(chip->pwmd, &pwmstate);
                if (ret)
-                       return dev_err_probe(chip->dev, ret,
-                                            "error setting pwm device\n");
+                       return dev_err_probe(dev, ret, "error setting pwm device\n");
        }
 
        chip->pdata->status = FIRST_POWER_ON;