iio:adc:twl6030: Switch from CONFIG_PM_SLEEP guards to pm_sleep_ptr() etc
authorJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 30 Jan 2022 19:31:11 +0000 (19:31 +0000)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Fri, 18 Feb 2022 11:43:12 +0000 (11:43 +0000)
Letting the compiler remove these functions when the kernel is built
without CONFIG_PM_SLEEP support is simpler and less error prone than the
use of ifdef based config guards.

Removing instances of this approach from IIO also stops them being
copied into new drivers.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Paul Cercueil <paul@crapouillou.net>
Link: https://lore.kernel.org/r/20220130193147.279148-15-jic23@kernel.org
drivers/iio/adc/twl6030-gpadc.c

index afdb59e0b5267395b2fa7c8b3af0a6aa2b052e2a..4966997b531975ac2f021eadfc869ff224591d48 100644 (file)
@@ -944,7 +944,6 @@ static int twl6030_gpadc_remove(struct platform_device *pdev)
        return 0;
 }
 
-#ifdef CONFIG_PM_SLEEP
 static int twl6030_gpadc_suspend(struct device *pdev)
 {
        int ret;
@@ -968,17 +967,16 @@ static int twl6030_gpadc_resume(struct device *pdev)
 
        return 0;
 };
-#endif
 
-static SIMPLE_DEV_PM_OPS(twl6030_gpadc_pm_ops, twl6030_gpadc_suspend,
-                                       twl6030_gpadc_resume);
+static DEFINE_SIMPLE_DEV_PM_OPS(twl6030_gpadc_pm_ops, twl6030_gpadc_suspend,
+                               twl6030_gpadc_resume);
 
 static struct platform_driver twl6030_gpadc_driver = {
        .probe          = twl6030_gpadc_probe,
        .remove         = twl6030_gpadc_remove,
        .driver         = {
                .name   = DRIVER_NAME,
-               .pm     = &twl6030_gpadc_pm_ops,
+               .pm     = pm_sleep_ptr(&twl6030_gpadc_pm_ops),
                .of_match_table = of_twl6030_match_tbl,
        },
 };