smb: client: fix potential UAF in cifs_stats_proc_write()
authorPaulo Alcantara <pc@manguebit.com>
Tue, 2 Apr 2024 19:33:55 +0000 (16:33 -0300)
committerSteve French <stfrench@microsoft.com>
Wed, 3 Apr 2024 19:43:45 +0000 (14:43 -0500)
Skip sessions that are being teared down (status == SES_EXITING) to
avoid UAF.

Cc: stable@vger.kernel.org
Signed-off-by: Paulo Alcantara (Red Hat) <pc@manguebit.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/client/cifs_debug.c

index c9aec9a38ad36d3c830925a4ce73b4f06a66658a..8535c990746260b24845a5da8ae484f87402602d 100644 (file)
@@ -678,6 +678,8 @@ static ssize_t cifs_stats_proc_write(struct file *file,
                        }
 #endif /* CONFIG_CIFS_STATS2 */
                        list_for_each_entry(ses, &server->smb_ses_list, smb_ses_list) {
+                               if (cifs_ses_exiting(ses))
+                                       continue;
                                list_for_each_entry(tcon, &ses->tcon_list, tcon_list) {
                                        atomic_set(&tcon->num_smbs_sent, 0);
                                        spin_lock(&tcon->stat_lock);