hvcs: Use vhangup in hotplug remove

When hotplug removing an hvcs device, we need to ensure the
hangup processing is done prior to exiting the remove function,
so use tty_vhangup to do the hangup processing directly
rather than using tty_hangup which simply schedules the hangup
work for later execution.

Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
Link: https://lore.kernel.org/r/20230203155802.404324-5-brking@linux.vnet.ibm.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/tty/hvc/hvcs.c b/drivers/tty/hvc/hvcs.c
index 8d40b20de27740245d095fc898c6592a6364bea6..ecf24195b1e9ce2aca0bad418fa787fcebae1a9a 100644 (file)
--- a/drivers/tty/hvc/hvcs.c
+++ b/drivers/tty/hvc/hvcs.c
@@ -810,12 +810,11 @@ static void hvcs_remove(struct vio_dev *dev)
        tty_port_put(&hvcsd->port);
 
        /*
-        * The hangup is a scheduled function which will auto chain call
-        * hvcs_hangup.  The tty should always be valid at this time unless a
+        * The tty should always be valid at this time unless a
         * simultaneous tty close already cleaned up the hvcs_struct.
         */
        if (tty) {
-               tty_hangup(tty);
+               tty_vhangup(tty);
                tty_kref_put(tty);
        }