drm/xe: Simplify final return from xe_irq_install()
authorGustavo Sousa <gustavo.sousa@intel.com>
Fri, 15 Sep 2023 22:02:33 +0000 (19:02 -0300)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Thu, 21 Dec 2023 16:41:14 +0000 (11:41 -0500)
At the end of the function, we will always return err no matter it's
value. Simplify this by just returning the result of
drmm_add_action_or_reset().

Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Link: https://lore.kernel.org/r/20230915220233.59736-1-gustavo.sousa@intel.com
Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/xe/xe_irq.c

index ff71a3aa08ce4af5386b3067d9beab5397aa05ed..dec3d518b3fc4030af8e0301743c2506b6929f0b 100644 (file)
@@ -592,11 +592,7 @@ int xe_irq_install(struct xe_device *xe)
 
        xe_irq_postinstall(xe);
 
-       err = drmm_add_action_or_reset(&xe->drm, irq_uninstall, xe);
-       if (err)
-               return err;
-
-       return err;
+       return drmm_add_action_or_reset(&xe->drm, irq_uninstall, xe);
 }
 
 void xe_irq_shutdown(struct xe_device *xe)