pwm: stm32-lp: Don't modify HW state in .remove() callback
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Wed, 7 Jul 2021 16:27:53 +0000 (18:27 +0200)
committerThierry Reding <thierry.reding@gmail.com>
Thu, 2 Sep 2021 19:38:37 +0000 (21:38 +0200)
A consumer is expected to disable a PWM before calling pwm_put(). And if
they didn't there is hopefully a good reason (or the consumer needs
fixing). Also if disabling an enabled PWM was the right thing to do,
this should better be done in the framework instead of in each low level
driver.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-stm32-lp.c

index 93dd03618465bb3deff9e8eaa3abe15405740654..e4a10aac354d613ae75de4534ded3e69448a6959 100644 (file)
@@ -222,8 +222,6 @@ static int stm32_pwm_lp_remove(struct platform_device *pdev)
 {
        struct stm32_pwm_lp *priv = platform_get_drvdata(pdev);
 
-       pwm_disable(&priv->chip.pwms[0]);
-
        return pwmchip_remove(&priv->chip);
 }