Restore gcc check in mips asm/unroll.h
authorCesar Eduardo Barros <cesarb@cesarb.eti.br>
Thu, 9 Jul 2020 22:11:02 +0000 (19:11 -0300)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 10 Jul 2020 01:03:47 +0000 (18:03 -0700)
While raising the gcc version requirement to 4.9, the compile-time check
in the unroll macro was accidentally changed from being used on gcc and
clang to being used on clang only.

Restore the gcc check, changing it from "gcc >= 4.7" to "all gcc".

[ We should probably remove this all entirely: if we remove the check
  for CLANG, then the check for GCC can go away. Older versions of clang
  are not really appropriate or supported for kernel builds - Linus ]

Fixes: 6ec4476ac825 ("Raise gcc version requirement to 4.9")
Signed-off-by: Cesar Eduardo Barros <cesarb@cesarb.eti.br>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
arch/mips/include/asm/unroll.h

index 8ed660adc84fe6085acb22c281020e22ea09594e..49009319ac2cd6e733b72e5fecde689cd17fbca0 100644 (file)
@@ -25,7 +25,8 @@
         * generate reasonable code for the switch statement,   \
         * so we skip the sanity check for those compilers.     \
         */                                                     \
-       BUILD_BUG_ON((CONFIG_CLANG_VERSION >= 80000) &&         \
+       BUILD_BUG_ON((CONFIG_CC_IS_GCC ||                       \
+                     CONFIG_CLANG_VERSION >= 80000) &&         \
                     !__builtin_constant_p(times));             \
                                                                \
        switch (times) {                                        \