net/mlx5: Dump of fw_fatal use updated devlink binary interface

Remove redundant code from fw_fatal reporter's dump callback. Use
updated devlink interface of binary fmsg pair which breaks the output
into chunks internally.

Signed-off-by: Aya Levin <ayal@mellanox.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Acked-by: Saeed Mahameed <saeedm@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/health.c b/drivers/net/ethernet/mellanox/mlx5/core/health.c
index e718170a80c39564e7f08ff3d6edd2fa19731cfd..d9f4e8c59c1fb1c6953a101d12cd7b202bf1e339 100644 (file)
--- a/drivers/net/ethernet/mellanox/mlx5/core/health.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/health.c
@@ -555,7 +555,6 @@ mlx5_fw_fatal_reporter_recover(struct devlink_health_reporter *reporter,
        return mlx5_health_try_recover(dev);
 }
 
-#define MLX5_CR_DUMP_CHUNK_SIZE 256
 static int
 mlx5_fw_fatal_reporter_dump(struct devlink_health_reporter *reporter,
                            struct devlink_fmsg *fmsg, void *priv_ctx,
@@ -564,8 +563,6 @@ mlx5_fw_fatal_reporter_dump(struct devlink_health_reporter *reporter,
        struct mlx5_core_dev *dev = devlink_health_reporter_priv(reporter);
        u32 crdump_size = dev->priv.health.crdump_size;
        u32 *cr_data;
-       u32 data_size;
-       u32 offset;
        int err;
 
        if (!mlx5_core_is_pf(dev))
@@ -586,20 +583,7 @@ mlx5_fw_fatal_reporter_dump(struct devlink_health_reporter *reporter,
                        goto free_data;
        }
 
-       err = devlink_fmsg_arr_pair_nest_start(fmsg, "crdump_data");
-       if (err)
-               goto free_data;
-       for (offset = 0; offset < crdump_size; offset += data_size) {
-               if (crdump_size - offset < MLX5_CR_DUMP_CHUNK_SIZE)
-                       data_size = crdump_size - offset;
-               else
-                       data_size = MLX5_CR_DUMP_CHUNK_SIZE;
-               err = devlink_fmsg_binary_put(fmsg, (char *)cr_data + offset,
-                                             data_size);
-               if (err)
-                       goto free_data;
-       }
-       err = devlink_fmsg_arr_pair_nest_end(fmsg);
+       err = devlink_fmsg_binary_pair_put(fmsg, "crdump_data", cr_data, crdump_size);
 
 free_data:
        kvfree(cr_data);