hw/net/virtio-net.c: fix crash in iov_copy()
authorDmitry Frolov <frolov@swemel.ru>
Thu, 13 Jun 2024 14:35:30 +0000 (17:35 +0300)
committerMichael S. Tsirkin <mst@redhat.com>
Mon, 1 Jul 2024 21:16:05 +0000 (17:16 -0400)
A crash found while fuzzing device virtio-net-socket-check-used.
Assertion "offset == 0" in iov_copy() fails if less than guest_hdr_len bytes
were transmited.

Signed-off-by: Dmitry Frolov <frolov@swemel.ru>
Message-Id: <20240613143529.602591-2-frolov@swemel.ru>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
hw/net/virtio-net.c

index 9c7e85caea11a8f24ebb4d7aa0743098b9db35d1..8f309727086925a7ce20e772b855b5d3304381ab 100644 (file)
@@ -2735,6 +2735,10 @@ static int32_t virtio_net_flush_tx(VirtIONetQueue *q)
          */
         assert(n->host_hdr_len <= n->guest_hdr_len);
         if (n->host_hdr_len != n->guest_hdr_len) {
+            if (iov_size(out_sg, out_num) < n->guest_hdr_len) {
+                virtio_error(vdev, "virtio-net header is invalid");
+                goto detach;
+            }
             unsigned sg_num = iov_copy(sg, ARRAY_SIZE(sg),
                                        out_sg, out_num,
                                        0, n->host_hdr_len);