ASoC: SOF: Intel: mtl: call dsp dump when boot retry fails

Call snd_sof_dsp_dbg_dump() with the same flags/dump_msg
as used in function hda_loader.c/cl_dsp_init().

Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Signed-off-by: Yong Zhi <yong.zhi@intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://lore.kernel.org/r/20231127105235.30071-1-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/sound/soc/sof/intel/mtl.c b/sound/soc/sof/intel/mtl.c
index 254dbbeac1d076cc062190693a1ddf68a5727342..3ef9e5c3702837749d35afb08c1b6bb7c38d537e 100644 (file)
--- a/sound/soc/sof/intel/mtl.c
+++ b/sound/soc/sof/intel/mtl.c
@@ -440,7 +440,8 @@ int mtl_dsp_cl_init(struct snd_sof_dev *sdev, int stream_tag, bool imr_boot)
        struct sof_intel_hda_dev *hda = sdev->pdata->hw_pdata;
        const struct sof_intel_dsp_desc *chip = hda->desc;
        unsigned int status;
-       u32 ipc_hdr;
+       u32 ipc_hdr, flags;
+       char *dump_msg;
        int ret;
 
        /* step 1: purge FW request */
@@ -493,8 +494,18 @@ int mtl_dsp_cl_init(struct snd_sof_dev *sdev, int stream_tag, bool imr_boot)
        return 0;
 
 err:
-       snd_sof_dsp_dbg_dump(sdev, "MTL DSP init fail", 0);
+       flags = SOF_DBG_DUMP_PCI | SOF_DBG_DUMP_MBOX | SOF_DBG_DUMP_OPTIONAL;
+
+       /* after max boot attempts make sure that the dump is printed */
+       if (hda->boot_iteration == HDA_FW_BOOT_ATTEMPTS)
+               flags &= ~SOF_DBG_DUMP_OPTIONAL;
+
+       dump_msg = kasprintf(GFP_KERNEL, "Boot iteration failed: %d/%d",
+                            hda->boot_iteration, HDA_FW_BOOT_ATTEMPTS);
+       snd_sof_dsp_dbg_dump(sdev, dump_msg, flags);
        mtl_dsp_core_power_down(sdev, SOF_DSP_PRIMARY_CORE);
+
+       kfree(dump_msg);
        return ret;
 }