iommu/arm-smmu-v3: Pass smmu_domain to arm_enable/disable_ats()
authorJason Gunthorpe <jgg@nvidia.com>
Mon, 26 Feb 2024 17:07:20 +0000 (13:07 -0400)
committerWill Deacon <will@kernel.org>
Thu, 29 Feb 2024 15:12:22 +0000 (15:12 +0000)
The caller already has the domain, just pass it in. A following patch will
remove master->domain.

Tested-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
Tested-by: Nicolin Chen <nicolinc@nvidia.com>
Tested-by: Moritz Fischer <moritzf@google.com>
Reviewed-by: Nicolin Chen <nicolinc@nvidia.com>
Reviewed-by: Mostafa Saleh <smostafa@google.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Link: https://lore.kernel.org/r/9-v6-96275f25c39d+2d4-smmuv3_newapi_p1_jgg@nvidia.com
Signed-off-by: Will Deacon <will@kernel.org>
drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c

index ec05743ee2084738b690e948b91f673db4dedbc0..9d36ddecf2ad640cd47008c15e2c320ba769acbd 100644 (file)
@@ -2421,12 +2421,12 @@ static bool arm_smmu_ats_supported(struct arm_smmu_master *master)
        return dev_is_pci(dev) && pci_ats_supported(to_pci_dev(dev));
 }
 
-static void arm_smmu_enable_ats(struct arm_smmu_master *master)
+static void arm_smmu_enable_ats(struct arm_smmu_master *master,
+                               struct arm_smmu_domain *smmu_domain)
 {
        size_t stu;
        struct pci_dev *pdev;
        struct arm_smmu_device *smmu = master->smmu;
-       struct arm_smmu_domain *smmu_domain = master->domain;
 
        /* Don't enable ATS at the endpoint if it's not enabled in the STE */
        if (!master->ats_enabled)
@@ -2442,10 +2442,9 @@ static void arm_smmu_enable_ats(struct arm_smmu_master *master)
                dev_err(master->dev, "Failed to enable ATS (STU %zu)\n", stu);
 }
 
-static void arm_smmu_disable_ats(struct arm_smmu_master *master)
+static void arm_smmu_disable_ats(struct arm_smmu_master *master,
+                                struct arm_smmu_domain *smmu_domain)
 {
-       struct arm_smmu_domain *smmu_domain = master->domain;
-
        if (!master->ats_enabled)
                return;
 
@@ -2514,7 +2513,7 @@ static void arm_smmu_detach_dev(struct arm_smmu_master *master)
        if (!smmu_domain)
                return;
 
-       arm_smmu_disable_ats(master);
+       arm_smmu_disable_ats(master, smmu_domain);
 
        spin_lock_irqsave(&smmu_domain->devices_lock, flags);
        list_del(&master->domain_head);
@@ -2636,7 +2635,7 @@ static int arm_smmu_attach_dev(struct iommu_domain *domain, struct device *dev)
                break;
        }
 
-       arm_smmu_enable_ats(master);
+       arm_smmu_enable_ats(master, smmu_domain);
        goto out_unlock;
 
 out_list_del: