tipc: Remove redundant call to TLV_SPACE()

The purpose of TLV_SPACE() is to add the TLV descriptor size to the size of
the TLV value passed as argument and align the resulting size to
TLV_ALIGNTO.

tipc_tlv_alloc() calls TLV_SPACE() on its argument. In other words,
tipc_tlv_alloc() takes its argument as the size of the TLV value. So the
call to TLV_SPACE() in tipc_get_err_tlv() is redundant. Let's remove this
redundancy.

Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Shigeru Yoshida <syoshida@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/tipc/netlink_compat.c b/net/tipc/netlink_compat.c
index c763008a8adbaa0538615431984c4f95926bcc3f..079aebb16ed8ff2f1b6f37b12fdaa3c57241cd87 100644 (file)
--- a/net/tipc/netlink_compat.c
+++ b/net/tipc/netlink_compat.c
@@ -168,7 +168,7 @@ static struct sk_buff *tipc_get_err_tlv(char *str)
        int str_len = strlen(str) + 1;
        struct sk_buff *buf;
 
-       buf = tipc_tlv_alloc(TLV_SPACE(str_len));
+       buf = tipc_tlv_alloc(str_len);
        if (buf)
                tipc_add_tlv(buf, TIPC_TLV_ERROR_STRING, str, str_len);