scsi/esp-pci: add g_assert() for fix clang analyzer warning in esp_pci_io_write()
authorChen Qun <kuhn.chenqun@huawei.com>
Wed, 25 Mar 2020 02:59:17 +0000 (10:59 +0800)
committerLaurent Vivier <laurent@vivier.eu>
Mon, 4 May 2020 09:17:27 +0000 (11:17 +0200)
Clang static code analyzer show warning:
  hw/scsi/esp-pci.c:198:9: warning: Value stored to 'size' is never read
        size = 4;
        ^      ~

Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20200325025919.21316-2-kuhn.chenqun@huawei.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
hw/scsi/esp-pci.c

index d5a1f9e0174886ccd4614037580c6f30ad365740..497a8d59019018f44aebb450f0a82f001c1bec00 100644 (file)
@@ -197,6 +197,7 @@ static void esp_pci_io_write(void *opaque, hwaddr addr,
         addr &= ~3;
         size = 4;
     }
+    g_assert(size >= 4);
 
     if (addr < 0x40) {
         /* SCSI core reg */