x86/mce: Remove redundant call to irq_work_queue()
authorGabriele Paoloni <gabriele.paoloni@intel.com>
Fri, 27 Nov 2020 16:18:18 +0000 (16:18 +0000)
committerBorislav Petkov <bp@suse.de>
Tue, 1 Dec 2020 17:54:32 +0000 (18:54 +0100)
Currently, __mc_scan_banks() in do_machine_check() does the following
callchain:

  __mc_scan_banks()->mce_log()->irq_work_queue(&mce_irq_work).

Hence, the call to irq_work_queue() below after __mc_scan_banks()
seems redundant. Just remove it.

Signed-off-by: Gabriele Paoloni <gabriele.paoloni@intel.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Reviewed-by: Tony Luck <tony.luck@intel.com>
Link: https://lkml.kernel.org/r/20201127161819.3106432-5-gabriele.paoloni@intel.com
arch/x86/kernel/cpu/mce/core.c

index 99da2e0b595b1b869ce817362bec8a6527026ad6..a9991a96445dbd43080ca840cf6149cec5845e79 100644 (file)
@@ -1406,9 +1406,6 @@ noinstr void do_machine_check(struct pt_regs *regs)
                }
        }
 
-       if (worst > 0)
-               irq_work_queue(&mce_irq_work);
-
        if (worst != MCE_AR_SEVERITY && !kill_it)
                goto out;