PCI: mvebu: Drop error data fabrication when config read fails

If config pci_ops.read() methods return failure, the PCI_OP_READ() and
PCI_USER_READ_CONFIG() wrappers use PCI_SET_ERROR_RESPONSE() to set the
data value, so there's no need to set it in the pci_ops.read() methods
themselves.

Drop the unnecessary data value fabrication when pci_ops.read() fails.

Link: https://lore.kernel.org/r/f30264b137b1282ffda34d336e8060bb13d60b98.1637243717.git.naveennaidu479@gmail.com
Signed-off-by: Naveen Naidu <naveennaidu479@gmail.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

diff --git a/drivers/pci/controller/pci-mvebu.c b/drivers/pci/controller/pci-mvebu.c
index ed13e81cd691d461708f2d7b798037fee15f8449..70a96af8cd2fc63d1b7f44c78bbf7af01eb454da 100644 (file)
--- a/drivers/pci/controller/pci-mvebu.c
+++ b/drivers/pci/controller/pci-mvebu.c
@@ -653,20 +653,16 @@ static int mvebu_pcie_rd_conf(struct pci_bus *bus, u32 devfn, int where,
        int ret;
 
        port = mvebu_pcie_find_port(pcie, bus, devfn);
-       if (!port) {
-               *val = 0xffffffff;
+       if (!port)
                return PCIBIOS_DEVICE_NOT_FOUND;
-       }
 
        /* Access the emulated PCI-to-PCI bridge */
        if (bus->number == 0)
                return pci_bridge_emul_conf_read(&port->bridge, where,
                                                 size, val);
 
-       if (!mvebu_pcie_link_up(port)) {
-               *val = 0xffffffff;
+       if (!mvebu_pcie_link_up(port))
                return PCIBIOS_DEVICE_NOT_FOUND;
-       }
 
        /* Access the real PCIe interface */
        ret = mvebu_pcie_hw_rd_conf(port, bus, devfn,