tty: serial: fsl_lpuart: disable Rx/Tx DMA in lpuart32_shutdown()
authorSherry Sun <sherry.sun@nxp.com>
Fri, 25 Nov 2022 10:19:52 +0000 (18:19 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 10 Mar 2023 08:39:37 +0000 (09:39 +0100)
[ Upstream commit 1d4bd0e4ae4ba95892bef919a8d4d3f08f122d7e ]

UARTBAUD_RDMAE and UARTBAUD_TDMAE are enabled in lpuart32_startup(), but
lpuart32_shutdown() not disable them, only free the dma ring buffer and
release the dma channels, so here disable the Rx/Tx DMA first in
lpuart32_shutdown().

Fixes: 42b68768e51b ("serial: fsl_lpuart: DMA support for 32-bit variant")
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
Link: https://lore.kernel.org/r/20221125101953.18753-3-sherry.sun@nxp.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/tty/serial/fsl_lpuart.c

index fc311df9f1c9d814921dc98d7f43a44ac79737a3..24f9001d10242152e278b20f0c5855c03ed5a19b 100644 (file)
@@ -1807,6 +1807,11 @@ static void lpuart32_shutdown(struct uart_port *port)
 
        spin_lock_irqsave(&port->lock, flags);
 
+       /* disable Rx/Tx DMA */
+       temp = lpuart32_read(port, UARTBAUD);
+       temp &= ~(UARTBAUD_TDMAE | UARTBAUD_RDMAE);
+       lpuart32_write(port, temp, UARTBAUD);
+
        /* disable Rx/Tx and interrupts */
        temp = lpuart32_read(port, UARTCTRL);
        temp &= ~(UARTCTRL_TE | UARTCTRL_RE |