media: s5p-g2d: Use platform_get_irq() to get the interrupt
authorLad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Tue, 11 Jan 2022 00:23:12 +0000 (01:23 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Fri, 28 Jan 2022 10:41:13 +0000 (11:41 +0100)
platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static
allocation of IRQ resources in DT core code, this causes an issue
when using hierarchical interrupt domains using "interrupts" property
in the node as this bypasses the hierarchical setup and messes up the
irq chaining.

In preparation for removal of static setup of IRQ resource from DT core
code use platform_get_irq().

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Acked-by: Ɓukasz Stelmach <l.stelmach@samsung.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/platform/s5p-g2d/g2d.c

index fa0bb31bd2b9795b9606372d6efe96dd6624139e..dd8864779a7cbffaaa6a3c525f1aff44580d8636 100644 (file)
@@ -623,7 +623,6 @@ static int g2d_probe(struct platform_device *pdev)
 {
        struct g2d_dev *dev;
        struct video_device *vfd;
-       struct resource *res;
        const struct of_device_id *of_id;
        int ret = 0;
 
@@ -664,14 +663,11 @@ static int g2d_probe(struct platform_device *pdev)
                goto put_clk_gate;
        }
 
-       res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
-       if (!res) {
-               dev_err(&pdev->dev, "failed to find IRQ\n");
-               ret = -ENXIO;
+       ret = platform_get_irq(pdev, 0);
+       if (ret < 0)
                goto unprep_clk_gate;
-       }
 
-       dev->irq = res->start;
+       dev->irq = ret;
 
        ret = devm_request_irq(&pdev->dev, dev->irq, g2d_isr,
                                                0, pdev->name, dev);