staging: vchiq: Release firmware handle on unbind
authorNicolas Saenz Julienne <nsaenzjulienne@suse.de>
Mon, 18 Jan 2021 12:32:40 +0000 (13:32 +0100)
committerNicolas Saenz Julienne <nsaenzjulienne@suse.de>
Mon, 22 Mar 2021 16:59:51 +0000 (17:59 +0100)
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware
interface when unbinding the device.

Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c

index 59e45dc03a977a049dd90aa3bea392c04ce86d7e..f270728372471a14ee41dff071b6f70af99e83d9 100644 (file)
@@ -2734,7 +2734,7 @@ static int vchiq_probe(struct platform_device *pdev)
                return -ENOENT;
        }
 
-       drvdata->fw = rpi_firmware_get(fw_node);
+       drvdata->fw = devm_rpi_firmware_get(&pdev->dev, fw_node);
        of_node_put(fw_node);
        if (!drvdata->fw)
                return -EPROBE_DEFER;