ALSA: hda: hda_cs_dsp_ctl: Remove notification of driver write
authorSimon Trimmer <simont@opensource.cirrus.com>
Mon, 25 Mar 2024 11:31:27 +0000 (11:31 +0000)
committerMark Brown <broonie@kernel.org>
Wed, 3 Apr 2024 15:10:31 +0000 (16:10 +0100)
Any control that the driver is updating should be marked as SYSTEM and
therefore will not have an ALSA control to notify.

Signed-off-by: Simon Trimmer <simont@opensource.cirrus.com>
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://msgid.link/r/20240325113127.112783-6-rf@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/pci/hda/hda_cs_dsp_ctl.c

index 725544d81941037dcb3d96bcdca727b284828bee..7f2d35cf245b179512b72bf76dde90b9b52aec81 100644 (file)
@@ -201,7 +201,6 @@ int hda_cs_dsp_write_ctl(struct cs_dsp *dsp, const char *name, int type,
                         unsigned int alg, const void *buf, size_t len)
 {
        struct cs_dsp_coeff_ctl *cs_ctl;
-       struct hda_cs_dsp_coeff_ctl *ctl;
        int ret;
 
        mutex_lock(&dsp->pwr_lock);
@@ -211,13 +210,6 @@ int hda_cs_dsp_write_ctl(struct cs_dsp *dsp, const char *name, int type,
        if (ret < 0)
                return ret;
 
-       if (ret == 0 || (cs_ctl->flags & WMFW_CTL_FLAG_SYS))
-               return 0;
-
-       ctl = cs_ctl->priv;
-
-       snd_ctl_notify(ctl->card, SNDRV_CTL_EVENT_MASK_VALUE, &ctl->kctl->id);
-
        return 0;
 }
 EXPORT_SYMBOL_NS_GPL(hda_cs_dsp_write_ctl, SND_HDA_CS_DSP_CONTROLS);