wifi: iwlwifi: mvm: fix check in iwl_mvm_sta_fw_id_mask
authorJohannes Berg <johannes.berg@intel.com>
Mon, 25 Mar 2024 17:08:51 +0000 (18:08 +0100)
committerJohannes Berg <johannes.berg@intel.com>
Mon, 25 Mar 2024 17:14:02 +0000 (18:14 +0100)
In the previous commit, I renamed the variable to differentiate
mac80211/mvm link STA, but forgot to adjust the check. The one
from mac80211 is already non-NULL anyway, but the mvm one can
be NULL when the mac80211 isn't during link switch conditions.
Fix the check.

Fixes: 2783ab506eaa ("wifi: iwlwifi: mvm: select STA mask only for active links")
Reviewed-by: Daniel Gabay <daniel.gabay@intel.com>
Reviewed-by: Miriam Rachel Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://msgid.link/20240325180850.e95b442bafe9.I8c0119fce7b00cb4f65782930d2c167ed5dd0a6e@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c

index d9738fe6f9675008a2a449d352a64f6fa215b3c5..bd1d6ad44648c76a3d51be26015daee6bc2055f8 100644 (file)
@@ -36,7 +36,7 @@ u32 iwl_mvm_sta_fw_id_mask(struct iwl_mvm *mvm, struct ieee80211_sta *sta,
                mvm_link_sta =
                        rcu_dereference_check(mvmsta->link[link_id],
                                              lockdep_is_held(&mvm->mutex));
-               if (!link_sta)
+               if (!mvm_link_sta)
                        continue;
 
                result |= BIT(mvm_link_sta->sta_id);