iomap: Create large folios in the buffered write path
authorMatthew Wilcox (Oracle) <willy@infradead.org>
Fri, 19 May 2023 20:18:05 +0000 (16:18 -0400)
committerMatthew Wilcox (Oracle) <willy@infradead.org>
Mon, 24 Jul 2023 22:04:30 +0000 (18:04 -0400)
Use the size of the write as a hint for the size of the folio to create.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
fs/gfs2/bmap.c
fs/iomap/buffered-io.c
include/linux/iomap.h

index 8d611fbcf0bd738b8e1de1ce9b82be197eaf2b50..521d1e00a0ff4500ecdc6e128336ad6b372d7c96 100644 (file)
@@ -971,7 +971,7 @@ gfs2_iomap_get_folio(struct iomap_iter *iter, loff_t pos, unsigned len)
        if (status)
                return ERR_PTR(status);
 
-       folio = iomap_get_folio(iter, pos);
+       folio = iomap_get_folio(iter, pos, len);
        if (IS_ERR(folio))
                gfs2_trans_end(sdp);
        return folio;
index 94a6ae05e03ba9c85c626b6e50462f7395e5f4d4..00e0e94c953e97d4e42ff27b316fedf9fae79bb0 100644 (file)
@@ -461,16 +461,18 @@ EXPORT_SYMBOL_GPL(iomap_is_partially_uptodate);
  * iomap_get_folio - get a folio reference for writing
  * @iter: iteration structure
  * @pos: start offset of write
+ * @len: Suggested size of folio to create.
  *
  * Returns a locked reference to the folio at @pos, or an error pointer if the
  * folio could not be obtained.
  */
-struct folio *iomap_get_folio(struct iomap_iter *iter, loff_t pos)
+struct folio *iomap_get_folio(struct iomap_iter *iter, loff_t pos, size_t len)
 {
        fgf_t fgp = FGP_WRITEBEGIN | FGP_NOFS;
 
        if (iter->flags & IOMAP_NOWAIT)
                fgp |= FGP_NOWAIT;
+       fgp |= fgf_set_order(len);
 
        return __filemap_get_folio(iter->inode->i_mapping, pos >> PAGE_SHIFT,
                        fgp, mapping_gfp_mask(iter->inode->i_mapping));
@@ -597,7 +599,7 @@ static struct folio *__iomap_get_folio(struct iomap_iter *iter, loff_t pos,
        if (folio_ops && folio_ops->get_folio)
                return folio_ops->get_folio(iter, pos, len);
        else
-               return iomap_get_folio(iter, pos);
+               return iomap_get_folio(iter, pos, len);
 }
 
 static void __iomap_put_folio(struct iomap_iter *iter, loff_t pos, size_t ret,
index e2b836c2e119ae7d574874ddd35732a4e30e7d3a..80facb9c9e5be9d0093191b9986ccfcadd084166 100644 (file)
@@ -261,7 +261,7 @@ int iomap_file_buffered_write_punch_delalloc(struct inode *inode,
 int iomap_read_folio(struct folio *folio, const struct iomap_ops *ops);
 void iomap_readahead(struct readahead_control *, const struct iomap_ops *ops);
 bool iomap_is_partially_uptodate(struct folio *, size_t from, size_t count);
-struct folio *iomap_get_folio(struct iomap_iter *iter, loff_t pos);
+struct folio *iomap_get_folio(struct iomap_iter *iter, loff_t pos, size_t len);
 bool iomap_release_folio(struct folio *folio, gfp_t gfp_flags);
 void iomap_invalidate_folio(struct folio *folio, size_t offset, size_t len);
 int iomap_file_unshare(struct inode *inode, loff_t pos, loff_t len,