pinctrl: baytrail: Fix potential NULL pointer dereference
authorAditya Pakki <pakki001@umn.edu>
Tue, 12 Mar 2019 15:05:52 +0000 (10:05 -0500)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 18 Mar 2019 09:43:23 +0000 (12:43 +0300)
saved-context in byt_gpio_probe is allocated via devm_kcalloc and is
used without checking for NULL in later functions. This patch avoids
such a scenario.

Signed-off-by: Aditya Pakki <pakki001@umn.edu>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
drivers/pinctrl/intel/pinctrl-baytrail.c

index 241384ead4ed04d738b46819d256407c9dbf03ba..18d9ad504194788cd406dab062e9de52fca6d50f 100644 (file)
@@ -1710,6 +1710,8 @@ static int byt_gpio_probe(struct byt_gpio *vg)
 #ifdef CONFIG_PM_SLEEP
        vg->saved_context = devm_kcalloc(&vg->pdev->dev, gc->ngpio,
                                       sizeof(*vg->saved_context), GFP_KERNEL);
+       if (!vg->saved_context)
+               return -ENOMEM;
 #endif
        ret = devm_gpiochip_add_data(&vg->pdev->dev, gc, vg);
        if (ret) {