ASoC: fsl_micfil: Use of_device_get_match_data()
authorFabio Estevam <festevam@gmail.com>
Mon, 18 Jan 2021 12:38:11 +0000 (09:38 -0300)
committerMark Brown <broonie@kernel.org>
Wed, 20 Jan 2021 18:47:31 +0000 (18:47 +0000)
The retrieval of driver data via of_device_get_match_data() can make
the code simpler.

Use of_device_get_match_data() to simplify the code.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
Link: https://lore.kernel.org/r/20210118123815.1630882-2-festevam@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/fsl/fsl_micfil.c

index efc5daf53bbae504c654dae1a423107f57855ff6..8aedf6590b289d8e75f8a5c1a6e3aefcc53ac82f 100644 (file)
@@ -637,7 +637,6 @@ static irqreturn_t micfil_err_isr(int irq, void *devid)
 static int fsl_micfil_probe(struct platform_device *pdev)
 {
        struct device_node *np = pdev->dev.of_node;
-       const struct of_device_id *of_id;
        struct fsl_micfil *micfil;
        struct resource *res;
        void __iomem *regs;
@@ -651,11 +650,7 @@ static int fsl_micfil_probe(struct platform_device *pdev)
        micfil->pdev = pdev;
        strncpy(micfil->name, np->name, sizeof(micfil->name) - 1);
 
-       of_id = of_match_device(fsl_micfil_dt_ids, &pdev->dev);
-       if (!of_id || !of_id->data)
-               return -EINVAL;
-
-       micfil->soc = of_id->data;
+       micfil->soc = of_device_get_match_data(&pdev->dev);
 
        /* ipg_clk is used to control the registers
         * ipg_clk_app is used to operate the filter