xfs: move the dir2 data block fixed offsets to struct xfs_da_geometry
authorChristoph Hellwig <hch@lst.de>
Fri, 8 Nov 2019 23:05:38 +0000 (15:05 -0800)
committerDarrick J. Wong <darrick.wong@oracle.com>
Mon, 11 Nov 2019 00:54:24 +0000 (16:54 -0800)
Move the data block fixed offsets towards our structure for dir/attr
geometry parameters.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
fs/xfs/libxfs/xfs_da_btree.h
fs/xfs/libxfs/xfs_da_format.c
fs/xfs/libxfs/xfs_dir2.c
fs/xfs/libxfs/xfs_dir2.h
fs/xfs/libxfs/xfs_dir2_block.c
fs/xfs/libxfs/xfs_dir2_data.c
fs/xfs/libxfs/xfs_dir2_leaf.c
fs/xfs/libxfs/xfs_dir2_node.c
fs/xfs/libxfs/xfs_dir2_sf.c
fs/xfs/scrub/dir.c
fs/xfs/xfs_dir2_readdir.c

index 40110acf9f8a760165c45c4c41a301692e630e4a..4ac2cc87c28f57aa11e1784f771c22dc3b4feba0 100644 (file)
@@ -32,6 +32,9 @@ struct xfs_da_geometry {
        unsigned int    free_hdr_size;  /* dir2 free header size */
        unsigned int    free_max_bests; /* # of bests entries in dir2 free */
        xfs_dablk_t     freeblk;        /* blockno of free data v2 */
+
+       xfs_dir2_data_aoff_t data_first_offset;
+       size_t          data_entry_offset;
 };
 
 /*========================================================================
index 483f4ab6abb88363e0a51f387913b72e3741fdeb..0e35e613fbf3bb83011fe87b636ae94a0dc6948a 100644 (file)
@@ -105,33 +105,18 @@ static const struct xfs_dir_ops xfs_dir2_ops = {
        .data_get_ftype = xfs_dir2_data_get_ftype,
        .data_put_ftype = xfs_dir2_data_put_ftype,
        .data_bestfree_p = xfs_dir2_data_bestfree_p,
-
-       .data_first_offset =  sizeof(struct xfs_dir2_data_hdr) +
-                               XFS_DIR2_DATA_ENTSIZE(1) +
-                               XFS_DIR2_DATA_ENTSIZE(2),
-       .data_entry_offset = sizeof(struct xfs_dir2_data_hdr),
 };
 
 static const struct xfs_dir_ops xfs_dir2_ftype_ops = {
        .data_get_ftype = xfs_dir3_data_get_ftype,
        .data_put_ftype = xfs_dir3_data_put_ftype,
        .data_bestfree_p = xfs_dir2_data_bestfree_p,
-
-       .data_first_offset =  sizeof(struct xfs_dir2_data_hdr) +
-                               XFS_DIR3_DATA_ENTSIZE(1) +
-                               XFS_DIR3_DATA_ENTSIZE(2),
-       .data_entry_offset = sizeof(struct xfs_dir2_data_hdr),
 };
 
 static const struct xfs_dir_ops xfs_dir3_ops = {
        .data_get_ftype = xfs_dir3_data_get_ftype,
        .data_put_ftype = xfs_dir3_data_put_ftype,
        .data_bestfree_p = xfs_dir3_data_bestfree_p,
-
-       .data_first_offset =  sizeof(struct xfs_dir3_data_hdr) +
-                               XFS_DIR3_DATA_ENTSIZE(1) +
-                               XFS_DIR3_DATA_ENTSIZE(2),
-       .data_entry_offset = sizeof(struct xfs_dir3_data_hdr),
 };
 
 /*
index 77a297e7d91cc798305fb01e2f8430c506db8a6c..eccffe7a5ae06fd21fc35162d529827a80354f8e 100644 (file)
@@ -126,16 +126,24 @@ xfs_da_mount(
                dageo->node_hdr_size = sizeof(struct xfs_da3_node_hdr);
                dageo->leaf_hdr_size = sizeof(struct xfs_dir3_leaf_hdr);
                dageo->free_hdr_size = sizeof(struct xfs_dir3_free_hdr);
+               dageo->data_entry_offset =
+                               sizeof(struct xfs_dir3_data_hdr);
        } else {
                dageo->node_hdr_size = sizeof(struct xfs_da_node_hdr);
                dageo->leaf_hdr_size = sizeof(struct xfs_dir2_leaf_hdr);
                dageo->free_hdr_size = sizeof(struct xfs_dir2_free_hdr);
+               dageo->data_entry_offset =
+                               sizeof(struct xfs_dir2_data_hdr);
        }
        dageo->leaf_max_ents = (dageo->blksize - dageo->leaf_hdr_size) /
                        sizeof(struct xfs_dir2_leaf_entry);
        dageo->free_max_bests = (dageo->blksize - dageo->free_hdr_size) /
                        sizeof(xfs_dir2_data_off_t);
 
+       dageo->data_first_offset = dageo->data_entry_offset +
+                       xfs_dir2_data_entsize(mp, 1) +
+                       xfs_dir2_data_entsize(mp, 2);
+
        /*
         * Now we've set up the block conversion variables, we can calculate the
         * segment block constants using the geometry structure.
index 3f46954e93700576bdb0e7c8f52f4f03ffe018a1..830c70a20761fb334a4aa7b433098a83c066d902 100644 (file)
@@ -37,9 +37,6 @@ struct xfs_dir_ops {
                                uint8_t ftype);
        struct xfs_dir2_data_free *
                (*data_bestfree_p)(struct xfs_dir2_data_hdr *hdr);
-
-       xfs_dir2_data_aoff_t data_first_offset;
-       size_t  data_entry_offset;
 };
 
 extern const struct xfs_dir_ops *
index 35eda4d18cd8f3b35cecd348fb00efa0186a230c..9529a000838f8dd3425e68290aadb116cb7298bc 100644 (file)
@@ -937,7 +937,7 @@ xfs_dir2_leaf_to_block(
        while (dp->i_d.di_size > args->geo->blksize) {
                int hdrsz;
 
-               hdrsz = dp->d_ops->data_entry_offset;
+               hdrsz = args->geo->data_entry_offset;
                bestsp = xfs_dir2_leaf_bests_p(ltp);
                if (be16_to_cpu(bestsp[be32_to_cpu(ltp->bestcount) - 1]) ==
                                            args->geo->blksize - hdrsz) {
@@ -1045,6 +1045,7 @@ xfs_dir2_sf_to_block(
        struct xfs_inode        *dp = args->dp;
        struct xfs_mount        *mp = dp->i_mount;
        struct xfs_ifork        *ifp = XFS_IFORK_PTR(dp, XFS_DATA_FORK);
+       struct xfs_da_geometry  *geo = args->geo;
        xfs_dir2_db_t           blkno;          /* dir-relative block # (0) */
        xfs_dir2_data_hdr_t     *hdr;           /* block header */
        xfs_dir2_leaf_entry_t   *blp;           /* block leaf entries */
@@ -1059,7 +1060,7 @@ xfs_dir2_sf_to_block(
        int                     needlog;        /* need to log block header */
        int                     needscan;       /* need to scan block freespc */
        int                     newoffset;      /* offset from current entry */
-       unsigned int            offset = dp->d_ops->data_entry_offset;
+       unsigned int            offset = geo->data_entry_offset;
        xfs_dir2_sf_entry_t     *sfep;          /* sf entry pointer */
        xfs_dir2_sf_hdr_t       *oldsfp;        /* old shortform header  */
        xfs_dir2_sf_hdr_t       *sfp;           /* shortform header  */
index 3504b230ba1d3b6dfe7e6ea080576e1b60df5c00..c1a843f6a8daa8e4d097a086d3975cee072c3e86 100644 (file)
@@ -45,11 +45,10 @@ xfs_dir2_data_entry_tag_p(
  */
 static inline unsigned int
 xfs_dir2_data_max_leaf_entries(
-       const struct xfs_dir_ops        *ops,
        struct xfs_da_geometry          *geo)
 {
        return (geo->blksize - sizeof(struct xfs_dir2_block_tail) -
-               ops->data_entry_offset) /
+               geo->data_entry_offset) /
                        sizeof(struct xfs_dir2_leaf_entry);
 }
 
@@ -97,7 +96,7 @@ __xfs_dir3_data_check(
                return __this_address;
 
        hdr = bp->b_addr;
-       offset = ops->data_entry_offset;
+       offset = geo->data_entry_offset;
 
        switch (hdr->magic) {
        case cpu_to_be32(XFS_DIR3_BLOCK_MAGIC):
@@ -106,7 +105,7 @@ __xfs_dir3_data_check(
                lep = xfs_dir2_block_leaf_p(btp);
 
                if (be32_to_cpu(btp->count) >=
-                   xfs_dir2_data_max_leaf_entries(ops, geo))
+                   xfs_dir2_data_max_leaf_entries(geo))
                        return __this_address;
                break;
        case cpu_to_be32(XFS_DIR3_DATA_MAGIC):
@@ -586,9 +585,10 @@ xfs_dir2_data_freescan_int(
        struct xfs_dir2_data_hdr        *hdr,
        int                             *loghead)
 {
+       struct xfs_da_geometry          *geo = mp->m_dir_geo;
        struct xfs_dir2_data_free       *bf = ops->data_bestfree_p(hdr);
        void                            *addr = hdr;
-       unsigned int                    offset = ops->data_entry_offset;
+       unsigned int                    offset = geo->data_entry_offset;
        unsigned int                    end;
 
        ASSERT(hdr->magic == cpu_to_be32(XFS_DIR2_DATA_MAGIC) ||
@@ -602,7 +602,7 @@ xfs_dir2_data_freescan_int(
        memset(bf, 0, sizeof(*bf) * XFS_DIR2_DATA_FD_COUNT);
        *loghead = 1;
 
-       end = xfs_dir3_data_end_offset(mp->m_dir_geo, addr);
+       end = xfs_dir3_data_end_offset(geo, addr);
        while (offset < end) {
                struct xfs_dir2_data_unused     *dup = addr + offset;
                struct xfs_dir2_data_entry      *dep = addr + offset;
@@ -649,6 +649,7 @@ xfs_dir3_data_init(
        struct xfs_trans                *tp = args->trans;
        struct xfs_inode                *dp = args->dp;
        struct xfs_mount                *mp = dp->i_mount;
+       struct xfs_da_geometry          *geo = args->geo;
        struct xfs_buf                  *bp;
        struct xfs_dir2_data_hdr        *hdr;
        struct xfs_dir2_data_unused     *dup;
@@ -683,9 +684,8 @@ xfs_dir3_data_init(
                hdr->magic = cpu_to_be32(XFS_DIR2_DATA_MAGIC);
 
        bf = dp->d_ops->data_bestfree_p(hdr);
-       bf[0].offset = cpu_to_be16(dp->d_ops->data_entry_offset);
-       bf[0].length =
-               cpu_to_be16(args->geo->blksize - dp->d_ops->data_entry_offset);
+       bf[0].offset = cpu_to_be16(geo->data_entry_offset);
+       bf[0].length = cpu_to_be16(geo->blksize - geo->data_entry_offset);
        for (i = 1; i < XFS_DIR2_DATA_FD_COUNT; i++) {
                bf[i].length = 0;
                bf[i].offset = 0;
@@ -694,7 +694,7 @@ xfs_dir3_data_init(
        /*
         * Set up an unused entry for the block's body.
         */
-       dup = bp->b_addr + dp->d_ops->data_entry_offset;
+       dup = bp->b_addr + geo->data_entry_offset;
        dup->freetag = cpu_to_be16(XFS_DIR2_DATA_FREE_TAG);
        dup->length = bf[0].length;
        *xfs_dir2_data_unused_tag_p(dup) = cpu_to_be16((char *)dup - (char *)hdr);
@@ -747,8 +747,7 @@ xfs_dir2_data_log_header(
               hdr->magic == cpu_to_be32(XFS_DIR3_BLOCK_MAGIC));
 #endif
 
-       xfs_trans_log_buf(args->trans, bp, 0,
-                         args->dp->d_ops->data_entry_offset - 1);
+       xfs_trans_log_buf(args->trans, bp, 0, args->geo->data_entry_offset - 1);
 }
 
 /*
@@ -816,7 +815,7 @@ xfs_dir2_data_make_free(
         * If this isn't the start of the block, then back up to
         * the previous entry and see if it's free.
         */
-       if (offset > args->dp->d_ops->data_entry_offset) {
+       if (offset > args->geo->data_entry_offset) {
                __be16                  *tagp;  /* tag just before us */
 
                tagp = (__be16 *)((char *)hdr + offset) - 1;
index 4b6d590c58563c8ca270e8e4f8ae4421920b5dbc..2b327d1937f42a121fcb29e2472a3afc200236d1 100644 (file)
@@ -1343,6 +1343,7 @@ int                                               /* error */
 xfs_dir2_leaf_removename(
        xfs_da_args_t           *args)          /* operation arguments */
 {
+       struct xfs_da_geometry  *geo = args->geo;
        __be16                  *bestsp;        /* leaf block best freespace */
        xfs_dir2_data_hdr_t     *hdr;           /* data block header */
        xfs_dir2_db_t           db;             /* data block number */
@@ -1381,12 +1382,12 @@ xfs_dir2_leaf_removename(
         * Point to the leaf entry, use that to point to the data entry.
         */
        lep = &leafhdr.ents[index];
-       db = xfs_dir2_dataptr_to_db(args->geo, be32_to_cpu(lep->address));
+       db = xfs_dir2_dataptr_to_db(geo, be32_to_cpu(lep->address));
        dep = (xfs_dir2_data_entry_t *)((char *)hdr +
-               xfs_dir2_dataptr_to_off(args->geo, be32_to_cpu(lep->address)));
+               xfs_dir2_dataptr_to_off(geo, be32_to_cpu(lep->address)));
        needscan = needlog = 0;
        oldbest = be16_to_cpu(bf[0].length);
-       ltp = xfs_dir2_leaf_tail_p(args->geo, leaf);
+       ltp = xfs_dir2_leaf_tail_p(geo, leaf);
        bestsp = xfs_dir2_leaf_bests_p(ltp);
        if (be16_to_cpu(bestsp[db]) != oldbest) {
                xfs_buf_corruption_error(lbp);
@@ -1430,8 +1431,8 @@ xfs_dir2_leaf_removename(
         * If the data block is now empty then get rid of the data block.
         */
        if (be16_to_cpu(bf[0].length) ==
-                       args->geo->blksize - dp->d_ops->data_entry_offset) {
-               ASSERT(db != args->geo->datablk);
+           geo->blksize - geo->data_entry_offset) {
+               ASSERT(db != geo->datablk);
                if ((error = xfs_dir2_shrink_inode(args, db, dbp))) {
                        /*
                         * Nope, can't get rid of it because it caused
@@ -1473,7 +1474,7 @@ xfs_dir2_leaf_removename(
        /*
         * If the data block was not the first one, drop it.
         */
-       else if (db != args->geo->datablk)
+       else if (db != geo->datablk)
                dbp = NULL;
 
        xfs_dir3_leaf_check(dp, lbp);
@@ -1594,6 +1595,7 @@ xfs_dir2_leaf_trim_data(
        struct xfs_buf          *lbp,           /* leaf buffer */
        xfs_dir2_db_t           db)             /* data block number */
 {
+       struct xfs_da_geometry  *geo = args->geo;
        __be16                  *bestsp;        /* leaf bests table */
        struct xfs_buf          *dbp;           /* data block buffer */
        xfs_inode_t             *dp;            /* incore directory inode */
@@ -1607,13 +1609,13 @@ xfs_dir2_leaf_trim_data(
        /*
         * Read the offending data block.  We need its buffer.
         */
-       error = xfs_dir3_data_read(tp, dp, xfs_dir2_db_to_da(args->geo, db),
-                                  -1, &dbp);
+       error = xfs_dir3_data_read(tp, dp, xfs_dir2_db_to_da(geo, db), -1,
+                                  &dbp);
        if (error)
                return error;
 
        leaf = lbp->b_addr;
-       ltp = xfs_dir2_leaf_tail_p(args->geo, leaf);
+       ltp = xfs_dir2_leaf_tail_p(geo, leaf);
 
 #ifdef DEBUG
 {
@@ -1623,7 +1625,7 @@ xfs_dir2_leaf_trim_data(
        ASSERT(hdr->magic == cpu_to_be32(XFS_DIR2_DATA_MAGIC) ||
               hdr->magic == cpu_to_be32(XFS_DIR3_DATA_MAGIC));
        ASSERT(be16_to_cpu(bf[0].length) ==
-              args->geo->blksize - dp->d_ops->data_entry_offset);
+              geo->blksize - geo->data_entry_offset);
        ASSERT(db == be32_to_cpu(ltp->bestcount) - 1);
 }
 #endif
index b758da14cc7b956692750e806462456a2d0046f0..80659d009cbaabb4ca358f169d609f9645f254ad 100644 (file)
@@ -1263,6 +1263,7 @@ xfs_dir2_leafn_remove(
        xfs_da_state_blk_t      *dblk,          /* data block */
        int                     *rval)          /* resulting block needs join */
 {
+       struct xfs_da_geometry  *geo = args->geo;
        xfs_dir2_data_hdr_t     *hdr;           /* data block header */
        xfs_dir2_db_t           db;             /* data block number */
        struct xfs_buf          *dbp;           /* data block buffer */
@@ -1293,9 +1294,9 @@ xfs_dir2_leafn_remove(
        /*
         * Extract the data block and offset from the entry.
         */
-       db = xfs_dir2_dataptr_to_db(args->geo, be32_to_cpu(lep->address));
+       db = xfs_dir2_dataptr_to_db(geo, be32_to_cpu(lep->address));
        ASSERT(dblk->blkno == db);
-       off = xfs_dir2_dataptr_to_off(args->geo, be32_to_cpu(lep->address));
+       off = xfs_dir2_dataptr_to_off(geo, be32_to_cpu(lep->address));
        ASSERT(dblk->index == off);
 
        /*
@@ -1346,9 +1347,8 @@ xfs_dir2_leafn_remove(
                 * Convert the data block number to a free block,
                 * read in the free block.
                 */
-               fdb = xfs_dir2_db_to_fdb(args->geo, db);
-               error = xfs_dir2_free_read(tp, dp,
-                                          xfs_dir2_db_to_da(args->geo, fdb),
+               fdb = xfs_dir2_db_to_fdb(geo, db);
+               error = xfs_dir2_free_read(tp, dp, xfs_dir2_db_to_da(geo, fdb),
                                           &fbp);
                if (error)
                        return error;
@@ -1358,22 +1358,20 @@ xfs_dir2_leafn_remove(
                struct xfs_dir3_icfree_hdr freehdr;
 
                xfs_dir2_free_hdr_from_disk(dp->i_mount, &freehdr, free);
-               ASSERT(freehdr.firstdb == args->geo->free_max_bests *
-                       (fdb - xfs_dir2_byte_to_db(args->geo,
-                                                  XFS_DIR2_FREE_OFFSET)));
+               ASSERT(freehdr.firstdb == geo->free_max_bests *
+                       (fdb - xfs_dir2_byte_to_db(geo, XFS_DIR2_FREE_OFFSET)));
        }
 #endif
                /*
                 * Calculate which entry we need to fix.
                 */
-               findex = xfs_dir2_db_to_fdindex(args->geo, db);
+               findex = xfs_dir2_db_to_fdindex(geo, db);
                longest = be16_to_cpu(bf[0].length);
                /*
                 * If the data block is now empty we can get rid of it
                 * (usually).
                 */
-               if (longest == args->geo->blksize -
-                              dp->d_ops->data_entry_offset) {
+               if (longest == geo->blksize - geo->data_entry_offset) {
                        /*
                         * Try to punch out the data block.
                         */
@@ -1405,9 +1403,9 @@ xfs_dir2_leafn_remove(
         * Return indication of whether this leaf block is empty enough
         * to justify trying to join it with a neighbor.
         */
-       *rval = (args->geo->leaf_hdr_size +
+       *rval = (geo->leaf_hdr_size +
                 (uint)sizeof(leafhdr.ents) * (leafhdr.count - leafhdr.stale)) <
-               args->geo->magicpct;
+               geo->magicpct;
        return 0;
 }
 
index a41715c9b061b752ced3862e3c72057428b91b69..b5ac27442f9a82a7312822096426a644bf5bb596 100644 (file)
@@ -266,7 +266,7 @@ xfs_dir2_block_to_sf(
        int                     logflags;       /* inode logging flags */
        struct xfs_dir2_sf_entry *sfep;         /* shortform entry */
        struct xfs_dir2_sf_hdr  *sfp;           /* shortform directory header */
-       unsigned int            offset = dp->d_ops->data_entry_offset;
+       unsigned int            offset = args->geo->data_entry_offset;
        unsigned int            end;
 
        trace_xfs_dir2_block_to_sf(args);
@@ -538,7 +538,7 @@ xfs_dir2_sf_addname_hard(
         * to insert the new entry.
         * If it's going to end up at the end then oldsfep will point there.
         */
-       for (offset = dp->d_ops->data_first_offset,
+       for (offset = args->geo->data_first_offset,
              oldsfep = xfs_dir2_sf_firstentry(oldsfp),
              add_datasize = xfs_dir2_data_entsize(mp, args->namelen),
              eof = (char *)oldsfep == &buf[old_isize];
@@ -616,7 +616,7 @@ xfs_dir2_sf_addname_pick(
 
        sfp = (xfs_dir2_sf_hdr_t *)dp->i_df.if_u1.if_data;
        size = xfs_dir2_data_entsize(mp, args->namelen);
-       offset = dp->d_ops->data_first_offset;
+       offset = args->geo->data_first_offset;
        sfep = xfs_dir2_sf_firstentry(sfp);
        holefit = 0;
        /*
@@ -681,7 +681,7 @@ xfs_dir2_sf_check(
        xfs_dir2_sf_hdr_t       *sfp;           /* shortform structure */
 
        sfp = (xfs_dir2_sf_hdr_t *)dp->i_df.if_u1.if_data;
-       offset = dp->d_ops->data_first_offset;
+       offset = args->geo->data_first_offset;
        ino = xfs_dir2_sf_get_parent_ino(sfp);
        i8count = ino > XFS_DIR2_MAX_SHORT_INUM;
 
@@ -714,7 +714,6 @@ xfs_dir2_sf_verify(
        struct xfs_dir2_sf_entry        *sfep;
        struct xfs_dir2_sf_entry        *next_sfep;
        char                            *endp;
-       const struct xfs_dir_ops        *dops;
        struct xfs_ifork                *ifp;
        xfs_ino_t                       ino;
        int                             i;
@@ -725,11 +724,6 @@ xfs_dir2_sf_verify(
        uint8_t                         filetype;
 
        ASSERT(ip->i_d.di_format == XFS_DINODE_FMT_LOCAL);
-       /*
-        * xfs_iread calls us before xfs_setup_inode sets up ip->d_ops,
-        * so we can only trust the mountpoint to have the right pointer.
-        */
-       dops = xfs_dir_get_ops(mp, NULL);
 
        ifp = XFS_IFORK_PTR(ip, XFS_DATA_FORK);
        sfp = (struct xfs_dir2_sf_hdr *)ifp->if_u1.if_data;
@@ -750,7 +744,7 @@ xfs_dir2_sf_verify(
        error = xfs_dir_ino_validate(mp, ino);
        if (error)
                return __this_address;
-       offset = dops->data_first_offset;
+       offset = mp->m_dir_geo->data_first_offset;
 
        /* Check all reported entries */
        sfep = xfs_dir2_sf_firstentry(sfp);
index 82e3ed366524832e169705546b99147a9d483b66..132659bccb4f48ce35ee8d40bf927dbe90741198 100644 (file)
@@ -187,6 +187,7 @@ xchk_dir_rec(
        struct xfs_da_state_blk         *blk = &ds->state->path.blk[level];
        struct xfs_mount                *mp = ds->state->mp;
        struct xfs_inode                *dp = ds->dargs.dp;
+       struct xfs_da_geometry          *geo = mp->m_dir_geo;
        struct xfs_dir2_data_entry      *dent;
        struct xfs_buf                  *bp;
        struct xfs_dir2_leaf_entry      *ent;
@@ -220,11 +221,11 @@ xchk_dir_rec(
                return 0;
 
        /* Find the directory entry's location. */
-       db = xfs_dir2_dataptr_to_db(mp->m_dir_geo, ptr);
-       off = xfs_dir2_dataptr_to_off(mp->m_dir_geo, ptr);
-       rec_bno = xfs_dir2_db_to_da(mp->m_dir_geo, db);
+       db = xfs_dir2_dataptr_to_db(geo, ptr);
+       off = xfs_dir2_dataptr_to_off(geo, ptr);
+       rec_bno = xfs_dir2_db_to_da(geo, db);
 
-       if (rec_bno >= mp->m_dir_geo->leafblk) {
+       if (rec_bno >= geo->leafblk) {
                xchk_da_set_corrupt(ds, level);
                goto out;
        }
@@ -244,8 +245,8 @@ xchk_dir_rec(
        dent = bp->b_addr + off;
 
        /* Make sure we got a real directory entry. */
-       iter_off = mp->m_dir_inode_ops->data_entry_offset;
-       end = xfs_dir3_data_end_offset(mp->m_dir_geo, bp->b_addr);
+       iter_off = geo->data_entry_offset;
+       end = xfs_dir3_data_end_offset(geo, bp->b_addr);
        if (!end) {
                xchk_fblock_set_corrupt(ds->sc, XFS_DATA_FORK, rec_bno);
                goto out_relse;
@@ -392,7 +393,7 @@ xchk_directory_data_bestfree(
        }
 
        /* Make sure the bestfrees are actually the best free spaces. */
-       offset = d_ops->data_entry_offset;
+       offset = mp->m_dir_geo->data_entry_offset;
        end = xfs_dir3_data_end_offset(mp->m_dir_geo, bp->b_addr);
 
        /* Iterate the entries, stopping when we hit or go past the end. */
index edc57bed0f1f97ac4f98fc7e4ebc0e58ec551990..a893d2d0962038cb2a57e65b3f4cab50e27f93d7 100644 (file)
@@ -75,9 +75,9 @@ xfs_dir2_sf_getdents(
         * entries for "." and "..".
         */
        dot_offset = xfs_dir2_db_off_to_dataptr(geo, geo->datablk,
-                       dp->d_ops->data_entry_offset);
+                       geo->data_entry_offset);
        dotdot_offset = xfs_dir2_db_off_to_dataptr(geo, geo->datablk,
-                       dp->d_ops->data_entry_offset +
+                       geo->data_entry_offset +
                        xfs_dir2_data_entsize(mp, sizeof(".") - 1));
 
        /*
@@ -174,7 +174,7 @@ xfs_dir2_block_getdents(
         * Loop over the data portion of the block.
         * Each object is a real entry (dep) or an unused one (dup).
         */
-       offset = dp->d_ops->data_entry_offset;
+       offset = geo->data_entry_offset;
        end = xfs_dir3_data_end_offset(geo, bp->b_addr);
        while (offset < end) {
                struct xfs_dir2_data_unused     *dup = bp->b_addr + offset;
@@ -401,13 +401,13 @@ xfs_dir2_leaf_getdents(
                        /*
                         * Find our position in the block.
                         */
-                       offset = dp->d_ops->data_entry_offset;
+                       offset = geo->data_entry_offset;
                        byteoff = xfs_dir2_byte_to_off(geo, curoff);
                        /*
                         * Skip past the header.
                         */
                        if (byteoff == 0)
-                               curoff += dp->d_ops->data_entry_offset;
+                               curoff += geo->data_entry_offset;
                        /*
                         * Skip past entries until we reach our offset.
                         */