arm64: dts: qcom: sdm845-db845c: make pcie0_3p3v_dual always-on
authorCaleb Connolly <caleb.connolly@linaro.org>
Wed, 20 Mar 2024 12:25:11 +0000 (12:25 +0000)
committerBjorn Andersson <andersson@kernel.org>
Sun, 21 Apr 2024 17:31:34 +0000 (12:31 -0500)
This regulator is responsible not just for the PCIe 3.3v rail, but also
for 5v VBUS on the left USB port. There is currently no way to correctly
model this dependency on the USB controller, as a result when the PCIe
driver is not available (for example when in the initramfs) USB is
non-functional.

Until support is added for modelling this property (likely by
referencing it as a supply under a usb-connector node), let's just make
it always on. We don't target any power constrained usecases and this
regulator is required for USB to function correctly.

Fixes: 3f72e2d3e682 ("arm64: dts: qcom: Add Dragonboard 845c")
Suggested-by: Bjorn Andersson <quic_bjorande@quicinc.com>
Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Link: https://lore.kernel.org/r/20240320122515.3243711-1-caleb.connolly@linaro.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
arch/arm64/boot/dts/qcom/sdm845-db845c.dts

index 1f517328199b908655a5eed5c350641edd06ae1a..9a6d3d0c0ee43af337728546626ec70ce47b9ec6 100644 (file)
 
                gpio = <&tlmm 90 GPIO_ACTIVE_HIGH>;
                enable-active-high;
+               /*
+                * FIXME: this regulator is responsible for VBUS on the left USB
+                * port. Keep it always on until we can correctly model this
+                * relationship.
+                */
+               regulator-always-on;
 
                pinctrl-names = "default";
                pinctrl-0 = <&pcie0_pwren_state>;