selftests/bpf: Fix umount cgroup2 error in test_sockmap
authorGeliang Tang <tanggeliang@kylinos.cn>
Tue, 9 Apr 2024 05:18:40 +0000 (13:18 +0800)
committerMartin KaFai Lau <martin.lau@kernel.org>
Thu, 11 Apr 2024 17:29:25 +0000 (10:29 -0700)
This patch fixes the following "umount cgroup2" error in test_sockmap.c:

 (cgroup_helpers.c:353: errno: Device or resource busy) umount cgroup2

Cgroup fd cg_fd should be closed before cleanup_cgroup_environment().

Fixes: 13a5f3ffd202 ("bpf: Selftests, sockmap test prog run without setting cgroup")
Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
Acked-by: Yonghong Song <yonghong.song@linux.dev>
Link: https://lore.kernel.org/r/0399983bde729708773416b8488bac2cd5e022b8.1712639568.git.tanggeliang@kylinos.cn
Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>
tools/testing/selftests/bpf/test_sockmap.c

index 024a0faafb3be7ab97faaeba4e8f65ca6eedc0e4..43612de44fbf506b50e32a1755d5b7d8651724aa 100644 (file)
@@ -2104,9 +2104,9 @@ out:
                free(options.whitelist);
        if (options.blacklist)
                free(options.blacklist);
+       close(cg_fd);
        if (cg_created)
                cleanup_cgroup_environment();
-       close(cg_fd);
        return err;
 }