firmware: qcom_scm: remove a duplicative condition
authorJunlin Yang <yangjunlin@yulong.com>
Thu, 11 Mar 2021 01:32:35 +0000 (09:32 +0800)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Sat, 17 Jul 2021 04:48:41 +0000 (23:48 -0500)
Fixes coccicheck warnings:
./drivers/firmware/qcom_scm.c:324:20-22:
WARNING !A || A && B is equivalent to !A || B

Signed-off-by: Junlin Yang <yangjunlin@yulong.com>
Link: https://lore.kernel.org/r/20210311013235.1458-1-angkery@163.com
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
drivers/firmware/qcom_scm.c

index 33db4a65c2b21f856062a8b1c75b48fd6d611ae5..76bfa7ac2818692d42948526ab6c385defe273d9 100644 (file)
@@ -331,7 +331,7 @@ int qcom_scm_set_cold_boot_addr(void *entry, const cpumask_t *cpus)
                .owner = ARM_SMCCC_OWNER_SIP,
        };
 
-       if (!cpus || (cpus && cpumask_empty(cpus)))
+       if (!cpus || cpumask_empty(cpus))
                return -EINVAL;
 
        for_each_cpu(cpu, cpus) {