media: tc358746: Use the correct div_ function
authorRicardo Ribalda <ribalda@chromium.org>
Mon, 29 Apr 2024 15:05:01 +0000 (16:05 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Fri, 3 May 2024 10:16:08 +0000 (11:16 +0100)
fin does not fit in 32 bits in some arches.

Found by cocci:
drivers/media/i2c/tc358746.c:847:2-8: WARNING: do_div() does a 64-by-32 division, please consider using div64_ul instead.

Link: https://lore.kernel.org/linux-media/20240429-fix-cocci-v3-22-3c4865f5a4b0@chromium.org
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/i2c/tc358746.c

index d676adc4401bb5094be17bec25e54dfc7113d251..edf79107adc518ba8afedfba23185bab430ba3de 100644 (file)
@@ -844,8 +844,7 @@ static unsigned long tc358746_find_pll_settings(struct tc358746 *tc358746,
                        continue;
 
                tmp = fout * postdiv;
-               do_div(tmp, fin);
-               mul = tmp;
+               mul = div64_ul(tmp, fin);
                if (mul > 511)
                        continue;