staging: rtl8188eu: remove _dbg_dump_tx_info function

Remove the _dbg_dump_tx_info function from hal/rtl8188e_xmit.c, as
it doesn't actually do anything and is only called from one place.
It used to have some redundant debugging statements in it, but these
have now been removed anyway, so all it does is read information from
the adapter to set a variable 'dump_txdesc' which is then never used.
This fixes a kernel test robot warning.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
Link: https://lore.kernel.org/r/20210615223607.13863-8-phil@philpotter.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_xmit.c b/drivers/staging/rtl8188eu/hal/rtl8188e_xmit.c
index 0d5608766a0e398fd131d846de257d7fcbe96674..efa8960a7eb537e2f661b8af95b63a9852f21dc4 100644 (file)
--- a/drivers/staging/rtl8188eu/hal/rtl8188e_xmit.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188e_xmit.c
@@ -23,20 +23,3 @@ void handle_txrpt_ccx_88e(struct adapter *adapter, u8 *buf)
                                        RTW_SCTX_DONE_CCX_PKT_FAIL);
        }
 }
-
-void _dbg_dump_tx_info(struct adapter *padapter, int frame_tag,
-                      struct tx_desc *ptxdesc)
-{
-       u8 dmp_txpkt;
-       bool dump_txdesc = false;
-
-       rtw_hal_get_def_var(padapter, HAL_DEF_DBG_DUMP_TXPKT, &(dmp_txpkt));
-
-       if (dmp_txpkt == 1) {/* dump txdesc for data frame */
-               if ((frame_tag & 0x0f) == DATA_FRAMETAG)
-                       dump_txdesc = true;
-       } else if (dmp_txpkt == 2) {/* dump txdesc for mgnt frame */
-               if ((frame_tag & 0x0f) == MGNT_FRAMETAG)
-                       dump_txdesc = true;
-       }
-}

diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c b/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c
index 7ca0a45dd0c77683f470b17e2e190688a0b8254e..729d3bbf434397dc276b1c99ca326c246b7d56e7 100644 (file)
--- a/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c
@@ -318,7 +318,6 @@ static s32 update_txdesc(struct xmit_frame *pxmitframe, u8 *pmem, s32 sz, u8 bag
        rtl88eu_dm_set_tx_ant_by_tx_info(odmpriv, pmem, pattrib->mac_id);
 
        rtl8188eu_cal_txdesc_chksum(ptxdesc);
-       _dbg_dump_tx_info(adapt, pxmitframe->frame_tag, ptxdesc);
        return pull;
 }
 

diff --git a/drivers/staging/rtl8188eu/include/rtl8188e_xmit.h b/drivers/staging/rtl8188eu/include/rtl8188e_xmit.h
index 617c2273b41b0b8766dd0c5e061f1fa148feec90..72a2bb812c9a9b921ac2d82c8323aca17c676b78 100644 (file)
--- a/drivers/staging/rtl8188eu/include/rtl8188e_xmit.h
+++ b/drivers/staging/rtl8188eu/include/rtl8188e_xmit.h
@@ -154,7 +154,4 @@ bool rtl8188eu_xmitframe_complete(struct adapter *padapter,
 
 void handle_txrpt_ccx_88e(struct adapter *adapter, u8 *buf);
 
-void _dbg_dump_tx_info(struct adapter *padapter, int frame_tag,
-                      struct tx_desc *ptxdesc);
-
 #endif /* __RTL8188E_XMIT_H__ */