usb: dwc3-am62: Fix PHY core voltage selection
authorRoger Quadros <rogerq@kernel.org>
Tue, 27 Feb 2024 09:23:50 +0000 (11:23 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 5 Mar 2024 13:23:17 +0000 (13:23 +0000)
TRM information is outdated and design team has confirmed
that PHY_CORE_VOLTAGE should be 0 irrespective of
VDD_CORE voltage.

Signed-off-by: Roger Quadros <rogerq@kernel.org>
Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Link: https://lore.kernel.org/r/20240227-for-v6-9-am62-usb-errata-3-0-v4-3-0ada8ddb0767@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/dwc3/dwc3-am62.c

index ea6e29091c0c9af61e7e6e626189e32f55a527fc..09b1f5a1c4fb3eef31c4b9e193ec17a95312d923 100644 (file)
@@ -97,7 +97,8 @@
 #define USBSS_VBUS_STAT_SESSVALID      BIT(2)
 #define USBSS_VBUS_STAT_VBUSVALID      BIT(0)
 
-/* Mask for PHY PLL REFCLK */
+/* USB_PHY_CTRL register bits in CTRL_MMR */
+#define PHY_CORE_VOLTAGE_MASK  BIT(31)
 #define PHY_PLL_REFCLK_MASK    GENMASK(3, 0)
 
 #define DWC3_AM62_AUTOSUSPEND_DELAY    100
@@ -162,6 +163,13 @@ static int phy_syscon_pll_refclk(struct dwc3_am62 *am62)
 
        am62->offset = args.args[0];
 
+       /* Core voltage. PHY_CORE_VOLTAGE bit Recommended to be 0 always */
+       ret = regmap_update_bits(am62->syscon, am62->offset, PHY_CORE_VOLTAGE_MASK, 0);
+       if (ret) {
+               dev_err(dev, "failed to set phy core voltage\n");
+               return ret;
+       }
+
        ret = regmap_update_bits(am62->syscon, am62->offset, PHY_PLL_REFCLK_MASK, am62->rate_code);
        if (ret) {
                dev_err(dev, "failed to set phy pll reference clock rate\n");