bcachefs: Fix memleak in replicas_table_update()
authorBrett Holman <bholman.devel@gmail.com>
Fri, 10 Feb 2023 23:36:55 +0000 (16:36 -0700)
committerKent Overstreet <kent.overstreet@linux.dev>
Sun, 22 Oct 2023 21:09:50 +0000 (17:09 -0400)
Signed-off-by: Brett Holman <bholman.devel@gmail.com>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
fs/bcachefs/replicas.c

index 482bedf4be8ba2cd696dd5afae09230281ae8aa0..3bff21959d986d388043e978d1525888702b2be8 100644 (file)
@@ -299,13 +299,6 @@ static int replicas_table_update(struct bch_fs *c,
 
        memset(new_usage, 0, sizeof(new_usage));
 
-       for (i = 0; i < ARRAY_SIZE(new_usage); i++)
-               if (!(new_usage[i] = __alloc_percpu_gfp(bytes,
-                                       sizeof(u64), GFP_KERNEL)))
-                       goto err;
-
-       memset(new_usage, 0, sizeof(new_usage));
-
        for (i = 0; i < ARRAY_SIZE(new_usage); i++)
                if (!(new_usage[i] = __alloc_percpu_gfp(bytes,
                                        sizeof(u64), GFP_KERNEL)))