drm/i915: Read a shadowed mmio register for ggtt flush
authorVinay Belgaumkar <vinay.belgaumkar@intel.com>
Thu, 9 Nov 2023 19:21:48 +0000 (11:21 -0800)
committerJohn Harrison <John.C.Harrison@Intel.com>
Thu, 16 Nov 2023 01:09:48 +0000 (17:09 -0800)
We read RENDER_HEAD as a part of the flush. If GT is in
deeper sleep states, this could lead to read errors since we are
not using a forcewake. Safer to read a shadowed register instead.

Cc: John Harrison <john.c.harrison@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
Reviewed-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231109192148.475156-1-vinay.belgaumkar@intel.com
drivers/gpu/drm/i915/gt/intel_gt.c

index ed32bf5b15464e63efceedc7752e851dea8ad212..ea814ea5f700f6021f2394d71e3405083de45e89 100644 (file)
@@ -451,7 +451,7 @@ void intel_gt_flush_ggtt_writes(struct intel_gt *gt)
 
                spin_lock_irqsave(&uncore->lock, flags);
                intel_uncore_posting_read_fw(uncore,
-                                            RING_HEAD(RENDER_RING_BASE));
+                                            RING_TAIL(RENDER_RING_BASE));
                spin_unlock_irqrestore(&uncore->lock, flags);
        }
 }