perf symbol: Remove now unused symbol_conf.sort_by_name

Previously used to specify symbol_name_rb_node was in use.

Signed-off-by: Ian Rogers <irogers@google.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: Carsten Haitzler <carsten.haitzler@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Jason Wang <wangborong@cdjrlc.com>
Cc: Changbin Du <changbin.du@huawei.com>
Cc: Yang Jihong <yangjihong1@huawei.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/20230623054520.4118442-4-irogers@google.com
Signed-off-by: Namhyung Kim <namhyung@kernel.org>

diff --git a/tools/perf/builtin-kallsyms.c b/tools/perf/builtin-kallsyms.c
index 3751df744577a40c7a780fb364ebf846c5fe7cfc..7f75c5b73f261295241c4f006bb2d78d2d382fd9 100644 (file)
--- a/tools/perf/builtin-kallsyms.c
+++ b/tools/perf/builtin-kallsyms.c
@@ -62,7 +62,6 @@ int cmd_kallsyms(int argc, const char **argv)
        if (argc < 1)
                usage_with_options(kallsyms_usage, options);
 
-       symbol_conf.sort_by_name = true;
        symbol_conf.try_vmlinux_path = (symbol_conf.vmlinux_name == NULL);
        if (symbol__init(NULL) < 0)
                return -1;

diff --git a/tools/perf/builtin-lock.c b/tools/perf/builtin-lock.c
index 8b505e1e5002a680362a7e8f828bf2795ce2a18b..da36ace66d682eb189605a383959c000483185ee 100644 (file)
--- a/tools/perf/builtin-lock.c
+++ b/tools/perf/builtin-lock.c
@@ -1774,7 +1774,6 @@ static int __cmd_report(bool display_info)
        }
 
        /* for lock function check */
-       symbol_conf.sort_by_name = true;
        symbol_conf.allow_aliases = true;
        symbol__init(&session->header.env);
 
@@ -1904,7 +1903,6 @@ static int __cmd_contention(int argc, const char **argv)
                con.save_callstack = true;
 
        /* for lock function check */
-       symbol_conf.sort_by_name = true;
        symbol_conf.allow_aliases = true;
        symbol__init(&session->header.env);
 

diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index a31a23af5547ce5a794aad8960dabeafd4598c09..dcedfe00f04dbd7d5bfb4a3f36529b2d4f7c986e 100644 (file)
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -1676,7 +1676,6 @@ repeat:
                         * See symbol__browser_index.
                         */
                        symbol_conf.priv_size += sizeof(u32);
-                       symbol_conf.sort_by_name = true;
                }
                annotation_config__init(&report.annotation_opts);
        }

diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c
index aa44fdc84763f9b77a4e6f1245774b6cbc97157b..1f6557ce3b0ae1044bc4224e88a157ce94d635fe 100644 (file)
--- a/tools/perf/tests/builtin-test.c
+++ b/tools/perf/tests/builtin-test.c
@@ -542,7 +542,6 @@ int cmd_test(int argc, const char **argv)
                return run_workload(workload, argc, argv);
 
        symbol_conf.priv_size = sizeof(int);
-       symbol_conf.sort_by_name = true;
        symbol_conf.try_vmlinux_path = true;
 
        if (symbol__init(NULL) < 0)

diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
index 277cb8f84cbcb088bd41cfe8188876559e8598cb..16822a8a540ff15364ce9f7bc6b2339b28b51e0d 100644 (file)
--- a/tools/perf/util/probe-event.c
+++ b/tools/perf/util/probe-event.c
@@ -74,7 +74,6 @@ int init_probe_symbol_maps(bool user_only)
 {
        int ret;
 
-       symbol_conf.sort_by_name = true;
        symbol_conf.allow_aliases = true;
        ret = symbol__init(NULL);
        if (ret < 0) {

diff --git a/tools/perf/util/symbol_conf.h b/tools/perf/util/symbol_conf.h
index f26f81eb82529c19f43515eb09fd28646fabbda6..0b589570d1d095c1a20047cad399b7eb3a19a95a 100644 (file)
--- a/tools/perf/util/symbol_conf.h
+++ b/tools/perf/util/symbol_conf.h
@@ -18,7 +18,6 @@ struct symbol_conf {
                        show_kernel_path,
                        use_modules,
                        allow_aliases,
-                       sort_by_name,
                        show_nr_samples,
                        show_total_period,
                        use_callchain,