firmware: meson-sm: unmap out_base shmem in error path

When SM driver was introduced in [1], the code flow did not require
to unmap out_base shmem in case of errors inside probe().
During [2], the additional error path appeared, which requires unmap.

Patch adds iounmap() missed.

Links:
[1] https://lore.kernel.org/linux-amlogic/1466339944-602-2-git-send-email-carlo@caione.org/
[2] https://lore.kernel.org/linux-amlogic/1532613556-5398-1-git-send-email-narmstrong@baylibre.com/

Fixes: 0789724f86a5 ("firmware: meson_sm: Add serial number sysfs entry")
Signed-off-by: Evgeny Bachinin <EABachinin@salutedevices.com>
Acked-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/20231108125604.162383-3-EABachinin@salutedevices.com
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>

diff --git a/drivers/firmware/meson/meson_sm.c b/drivers/firmware/meson/meson_sm.c
index fb766e40a6316d099d710e469c6306867e1e0389..5d7f62fe1d5ff1ed10798358741e0c4c98f1a486 100644 (file)
--- a/drivers/firmware/meson/meson_sm.c
+++ b/drivers/firmware/meson/meson_sm.c
@@ -310,7 +310,7 @@ static int __init meson_sm_probe(struct platform_device *pdev)
                fw->sm_shmem_out_base = meson_sm_map_shmem(chip->cmd_shmem_out_base,
                                                           chip->shmem_size);
                if (WARN_ON(!fw->sm_shmem_out_base))
-                       goto out_in_base;
+                       goto unmap_in_base;
        }
 
        fw->chip = chip;
@@ -318,13 +318,15 @@ static int __init meson_sm_probe(struct platform_device *pdev)
        platform_set_drvdata(pdev, fw);
 
        if (devm_of_platform_populate(dev))
-               goto out_in_base;
+               goto unmap_out_base;
 
        pr_info("secure-monitor enabled\n");
 
        return 0;
 
-out_in_base:
+unmap_out_base:
+       iounmap(fw->sm_shmem_out_base);
+unmap_in_base:
        iounmap(fw->sm_shmem_in_base);
 out:
        return -EINVAL;