media: i2c: imx219: Remove unneeded goto
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Sun, 24 Sep 2023 15:33:04 +0000 (18:33 +0300)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Sat, 7 Oct 2023 08:55:47 +0000 (10:55 +0200)
Simplify the imx219_set_stream() by removing an unneeded goto statement,
and its corresponding error label. The natural flow of the function is
correct.

While at it, drop a useless comment.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/i2c/imx219.c

index dfc5ce574227696952799a6b6503ef60fb68a6cc..a12ebf288dd2c0cffd39f48bf785707297fccd72 100644 (file)
@@ -760,19 +760,11 @@ static int imx219_set_stream(struct v4l2_subdev *sd, int enable)
 
        state = v4l2_subdev_lock_and_get_active_state(sd);
 
-       if (enable) {
-               /*
-                * Apply default & customized values
-                * and then start streaming.
-                */
+       if (enable)
                ret = imx219_start_streaming(imx219, state);
-               if (ret)
-                       goto unlock;
-       } else {
+       else
                imx219_stop_streaming(imx219);
-       }
 
-unlock:
        v4l2_subdev_unlock_state(state);
        return ret;
 }