KVM: x86: Do host CPUID at load time to mask KVM cpu caps
authorSean Christopherson <sean.j.christopherson@intel.com>
Mon, 2 Mar 2020 23:56:52 +0000 (15:56 -0800)
committerPaolo Bonzini <pbonzini@redhat.com>
Mon, 16 Mar 2020 16:58:31 +0000 (17:58 +0100)
Mask kvm_cpu_caps based on host CPUID in preparation for overriding the
CPUID results during KVM_GET_SUPPORTED_CPUID instead of doing the
masking at runtime.

Note, masking may or may not be necessary, e.g. the kernel rarely, if
ever, sets real CPUID bits that are not supported by hardware.  But, the
code is cheap and only runs once at load, so an abundance of caution is
warranted.

No functional change intended.

Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/x86/kvm/cpuid.c

index d4ada8f604a9aa8cc7e061f9f5b77465ca5c9454..80fccfd937bb53b6bed5f3e0df5545fe4ed3cdd7 100644 (file)
@@ -263,8 +263,16 @@ out:
 
 static __always_inline void kvm_cpu_cap_mask(enum cpuid_leafs leaf, u32 mask)
 {
+       const struct cpuid_reg cpuid = x86_feature_cpuid(leaf * 32);
+       struct kvm_cpuid_entry2 entry;
+
        reverse_cpuid_check(leaf);
        kvm_cpu_caps[leaf] &= mask;
+
+       cpuid_count(cpuid.function, cpuid.index,
+                   &entry.eax, &entry.ebx, &entry.ecx, &entry.edx);
+
+       kvm_cpu_caps[leaf] &= *__cpuid_entry_get_reg(&entry, &cpuid);
 }
 
 void kvm_set_cpu_caps(void)