ASoC: Intel: SoC: skylake: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Also, if a debugfs call fails, userspace is notified with an error in
the log, so no need to log the error again.

Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Cc: Jie Yang <yang.jie@linux.intel.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.com>
Cc: alsa-devel@alsa-project.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/r/20190731131716.9764-1-gregkh@linuxfoundation.org
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/sound/soc/intel/skylake/skl-debug.c b/sound/soc/intel/skylake/skl-debug.c
index fb232428109f89cdaf788de94c4d61503cf77fa6..212370bf704c1c18289cbe5c578e14a444a23fc2 100644 (file)
--- a/sound/soc/intel/skylake/skl-debug.c
+++ b/sound/soc/intel/skylake/skl-debug.c
@@ -164,10 +164,8 @@ void skl_debug_init_module(struct skl_debug *d,
                        struct snd_soc_dapm_widget *w,
                        struct skl_module_cfg *mconfig)
 {
-       if (!debugfs_create_file(w->name, 0444,
-                               d->modules, mconfig,
-                               &mcfg_fops))
-               dev_err(d->dev, "%s: module debugfs init failed\n", w->name);
+       debugfs_create_file(w->name, 0444, d->modules, mconfig,
+                           &mcfg_fops);
 }
 
 static ssize_t fw_softreg_read(struct file *file, char __user *user_buf,
@@ -224,34 +222,18 @@ struct skl_debug *skl_debugfs_init(struct skl_dev *skl)
                return NULL;
 
        /* create the debugfs dir with platform component's debugfs as parent */
-       d->fs = debugfs_create_dir("dsp",
-                                  skl->component->debugfs_root);
-       if (IS_ERR(d->fs) || !d->fs) {
-               dev_err(&skl->pci->dev, "debugfs root creation failed\n");
-               return NULL;
-       }
+       d->fs = debugfs_create_dir("dsp", skl->component->debugfs_root);
 
        d->skl = skl;
        d->dev = &skl->pci->dev;
 
        /* now create the module dir */
        d->modules = debugfs_create_dir("modules", d->fs);
-       if (IS_ERR(d->modules) || !d->modules) {
-               dev_err(&skl->pci->dev, "modules debugfs create failed\n");
-               goto err;
-       }
 
-       if (!debugfs_create_file("fw_soft_regs_rd", 0444, d->fs, d,
-                                &soft_regs_ctrl_fops)) {
-               dev_err(d->dev, "fw soft regs control debugfs init failed\n");
-               goto err;
-       }
+       debugfs_create_file("fw_soft_regs_rd", 0444, d->fs, d,
+                           &soft_regs_ctrl_fops);
 
        return d;
-
-err:
-       debugfs_remove_recursive(d->fs);
-       return NULL;
 }
 
 void skl_debugfs_exit(struct skl_dev *skl)