PCI: vmd: Disable MSI remapping after suspend
authorNirmal Patel <nirmal.patel@linux.intel.com>
Wed, 9 Nov 2022 14:26:52 +0000 (07:26 -0700)
committerLorenzo Pieralisi <lpieralisi@kernel.org>
Fri, 11 Nov 2022 11:00:26 +0000 (12:00 +0100)
MSI remapping is disabled by VMD driver for Intel's Icelake and
newer systems in order to improve performance by setting
VMCONFIG_MSI_REMAP. By design VMCONFIG_MSI_REMAP register is cleared
by firmware during boot. The same register gets cleared when system
is put in S3 power state. VMD driver needs to set this register again
in order to avoid interrupt issues with devices behind VMD if MSI
remapping was disabled before.

Link: https://lore.kernel.org/r/20221109142652.450998-1-nirmal.patel@linux.intel.com
Fixes: ee81ee84f873 ("PCI: vmd: Disable MSI-X remapping when possible")
Signed-off-by: Nirmal Patel <nirmal.patel@linux.intel.com>
Signed-off-by: Lorenzo Pieralisi <lpieralisi@kernel.org>
Reviewed-by: Francisco Munoz <francisco.munoz.ruiz@linux.intel.com>
drivers/pci/controller/vmd.c

index e06e9f4fc50f72b40c72a8a7fb1105b5a8fca1bb..98e0746e681c90b3748b27603222e3509354b752 100644 (file)
@@ -980,6 +980,11 @@ static int vmd_resume(struct device *dev)
        struct vmd_dev *vmd = pci_get_drvdata(pdev);
        int err, i;
 
+       if (vmd->irq_domain)
+               vmd_set_msi_remapping(vmd, true);
+       else
+               vmd_set_msi_remapping(vmd, false);
+
        for (i = 0; i < vmd->msix_count; i++) {
                err = devm_request_irq(dev, vmd->irqs[i].virq,
                                       vmd_irq, IRQF_NO_THREAD,