gpiolib: acpi: Check for errors first in acpi_find_gpio()

It's better to parse the code when the usual pattern is being used,
i.e. checking for error condition first.

There is no functional or code generation change (tested in LLVM).

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
index f596edf89451c5ec6e80f7f8197402de0352ae9a..c2a33beeec50ff91b383a5e91ce9601ea396601d 100644 (file)
--- a/drivers/gpio/gpiolib-acpi.c
+++ b/drivers/gpio/gpiolib-acpi.c
@@ -973,10 +973,11 @@ struct gpio_desc *acpi_find_gpio(struct fwnode_handle *fwnode,
                else
                        desc = acpi_get_gpiod_from_data(fwnode,
                                                        propname, idx, &info);
-               if (!IS_ERR(desc))
-                       break;
                if (PTR_ERR(desc) == -EPROBE_DEFER)
                        return ERR_CAST(desc);
+
+               if (!IS_ERR(desc))
+                       break;
        }
 
        /* Then from plain _CRS GPIOs */