drm/xe: Fix error path in xe_guc_pc_start()
authorLucas De Marchi <lucas.demarchi@intel.com>
Thu, 3 Aug 2023 23:42:09 +0000 (16:42 -0700)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Thu, 21 Dec 2023 16:39:29 +0000 (11:39 -0500)
If the forcewake failed, put xe_device_mem_access.

Reviewed-by: Matthew Brost <matthew.brost@intel.com>
Link: https://lore.kernel.org/r/20230803234209.881924-2-lucas.demarchi@intel.com
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/xe/xe_guc_pc.c

index 19d743f92f438d081dbfe21bc62570c764e352c5..c03bb58e70497f7b063e745c01980de209896991 100644 (file)
@@ -825,7 +825,7 @@ int xe_guc_pc_start(struct xe_guc_pc *pc)
 
        ret = xe_force_wake_get(gt_to_fw(gt), XE_FORCEWAKE_ALL);
        if (ret)
-               return ret;
+               goto out_fail_force_wake;
 
        ret = pc_action_reset(pc);
        if (ret)
@@ -851,6 +851,7 @@ int xe_guc_pc_start(struct xe_guc_pc *pc)
 
 out:
        XE_WARN_ON(xe_force_wake_put(gt_to_fw(gt), XE_FORCEWAKE_ALL));
+out_fail_force_wake:
        xe_device_mem_access_put(pc_to_xe(pc));
        return ret;
 }