drm/bridge: Drop conditionals around of_node pointers
authorBiju Das <biju.das.jz@bp.renesas.com>
Thu, 31 Aug 2023 08:09:36 +0000 (09:09 +0100)
committerDouglas Anderson <dianders@chromium.org>
Wed, 6 Sep 2023 15:32:37 +0000 (08:32 -0700)
This patch is based on commit c9e358dfc4a8 ("driver-core: remove
conditionals around devicetree pointers").

Having conditional around the of_node pointer of the drm_bridge
structure turns out to make driver code use ugly #ifdef blocks. Drop the
conditionals to simplify drivers. While this slightly increases the size
of struct drm_bridge on non-OF system, the number of bridges used today
and foreseen tomorrow on those systems is very low, so this shouldn't be
an issue.

So drop #if conditionals by adding struct device_node forward declaration.

Suggested-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230831080938.47454-3-biju.das.jz@bp.renesas.com
include/drm/drm_bridge.h

index 2dd94224f17e8b907e46bb63bb0f93bb5090887c..cfb7dcdb66c4b0b5121042604236c347e9a262c4 100644 (file)
@@ -32,6 +32,8 @@
 #include <drm/drm_mode_object.h>
 #include <drm/drm_modes.h>
 
+struct device_node;
+
 struct drm_bridge;
 struct drm_bridge_timings;
 struct drm_connector;
@@ -716,10 +718,8 @@ struct drm_bridge {
        struct drm_encoder *encoder;
        /** @chain_node: used to form a bridge chain */
        struct list_head chain_node;
-#ifdef CONFIG_OF
        /** @of_node: device node pointer to the bridge */
        struct device_node *of_node;
-#endif
        /** @list: to keep track of all added bridges */
        struct list_head list;
        /**