ASoC: tas5720: add missing unwind goto in tas5720_codec_probe
authorYing Liu <lyre@hust.edu.cn>
Tue, 11 Apr 2023 17:09:12 +0000 (01:09 +0800)
committerMark Brown <broonie@kernel.org>
Wed, 12 Apr 2023 11:52:00 +0000 (12:52 +0100)
Smatch complains that missing unwind goto in tas5720_codec_probe.

When tas5720 has an invalid devtype, it is expected to invoke
regulator_bulk_disable to handle the failure. But the default
option return an error code directly. Fix it by reusing the
probe_fail label.

Signed-off-by: Ying Liu <lyre@hust.edu.cn>
Link: https://lore.kernel.org/r/20230411170912.1939906-1-lyre@hust.edu.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/tas5720.c

index de6d01c8fdd340012592f147278817c79f1ae108..4d27b60bd8043bc3b4935af60d2fe005ea38fb6c 100644 (file)
@@ -339,7 +339,8 @@ static int tas5720_codec_probe(struct snd_soc_component *component)
                break;
        default:
                dev_err(component->dev, "unexpected private driver data\n");
-               return -EINVAL;
+               ret = -EINVAL;
+               goto probe_fail;
        }
 
        if (device_id != expected_device_id)