staging: r8188eu: ROMVer is always zero

The variable ROMVer in struct HAL_VERSION is set to zero and never
changed. Remove it and replace its use with zero.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20220407192819.10661-4-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/r8188eu/hal/hal_com.c b/drivers/staging/r8188eu/hal/hal_com.c
index 7649f9919f672e1ee6d485e7fbe98ad89ec343af..910cc07f656caad4a31dd11edb74b8e1996b8f65 100644 (file)
--- a/drivers/staging/r8188eu/hal/hal_com.c
+++ b/drivers/staging/r8188eu/hal/hal_com.c
@@ -44,7 +44,7 @@ void dump_chip_info(struct HAL_VERSION        chip_vers)
 
        cnt += sprintf((buf + cnt), "1T1R_");
 
-       cnt += sprintf((buf + cnt), "RomVer(%d)\n", chip_vers.ROMVer);
+       cnt += sprintf((buf + cnt), "RomVer(%d)\n", 0);
 
        pr_info("%s", buf);
 }

diff --git a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
index 6811be95da9adb8cd13923bd79a5874956c02f0f..609138887b2559792fb75572bd695dc5d59f4378 100644 (file)
--- a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
+++ b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
@@ -505,7 +505,6 @@ void rtl8188e_read_chip_version(struct adapter *padapter)
 
        ChipVersion.VendorType = ((value32 & VENDOR_ID) ? CHIP_VENDOR_UMC : CHIP_VENDOR_TSMC);
        ChipVersion.CUTVersion = (value32 & CHIP_VER_RTL_MASK) >> CHIP_VER_RTL_SHIFT; /*  IC version (CUT) */
-       ChipVersion.ROMVer = 0; /*  ROM code version. */
 
        dump_chip_info(ChipVersion);
 

diff --git a/drivers/staging/r8188eu/include/HalVerDef.h b/drivers/staging/r8188eu/include/HalVerDef.h
index 56dadadb1a0f5f3515ff166f60a64fe36bf41210..7a530c7d57eb35a88781f312196bd1d783bf6cc9 100644 (file)
--- a/drivers/staging/r8188eu/include/HalVerDef.h
+++ b/drivers/staging/r8188eu/include/HalVerDef.h
@@ -25,7 +25,6 @@ struct HAL_VERSION {
        enum HAL_CHIP_TYPE      ChipType;
        enum HAL_CUT_VERSION    CUTVersion;
        enum HAL_VENDOR         VendorType;
-       u8                      ROMVer;
 };
 
 /*  Get element */