rtc: ds1511: remove partial alarm support
authorAlexandre Belloni <alexandre.belloni@bootlin.com>
Tue, 27 Feb 2024 23:04:24 +0000 (00:04 +0100)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Thu, 29 Feb 2024 21:15:47 +0000 (22:15 +0100)
The RTC core will always provide an alarm with all its members set, it is
not necessary to support partial alarms.

Link: https://lore.kernel.org/r/20240227230431.1837717-9-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-ds1511.c

index c81f464e6a501f2e9877690250ed77d313215220..d5d59a948c595104b95b33b0847ace1a74edfcf2 100644 (file)
@@ -196,14 +196,10 @@ static int ds1511_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alrm)
                pdata->irqen |= RTC_AF;
 
        spin_lock_irqsave(&pdata->lock, flags);
-       rtc_write(pdata->alrm_mday < 0 ? 0x80 : bin2bcd(pdata->alrm_mday) & 0x3f,
-              DS1511_AM4_DATE);
-       rtc_write(pdata->alrm_hour < 0 ? 0x80 : bin2bcd(pdata->alrm_hour) & 0x3f,
-              DS1511_AM3_HOUR);
-       rtc_write(pdata->alrm_min < 0 ? 0x80 : bin2bcd(pdata->alrm_min) & 0x7f,
-              DS1511_AM2_MIN);
-       rtc_write(pdata->alrm_sec < 0 ? 0x80 : bin2bcd(pdata->alrm_sec) & 0x7f,
-              DS1511_AM1_SEC);
+       rtc_write(bin2bcd(pdata->alrm_mday) & 0x3f, DS1511_AM4_DATE);
+       rtc_write(bin2bcd(pdata->alrm_hour) & 0x3f, DS1511_AM3_HOUR);
+       rtc_write(bin2bcd(pdata->alrm_min) & 0x7f, DS1511_AM2_MIN);
+       rtc_write(bin2bcd(pdata->alrm_sec) & 0x7f, DS1511_AM1_SEC);
        ds1511_rtc_alarm_enable(alrm->enabled);
 
        rtc_read(DS1511_CONTROL_A);     /* clear interrupts */