staging: rtl8723bs: remove assignment in condition in core/rtw_ieee80211.c
authorFabio Aiuto <fabioaiuto83@gmail.com>
Wed, 24 Mar 2021 15:50:34 +0000 (16:50 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 26 Mar 2021 14:05:07 +0000 (15:05 +0100)
fix the following checkpatch warning:

ERROR: do not use assignment in if condition
1118: FILE: drivers/staging/rtl8723bs/core/rtw_ieee80211.c:1118:
+ if ((addr = of_get_property(np, "local-mac-address", &len)) &&

Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/8e784a7e1407924724c97398af8e5aeb23460612.1616600897.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/core/rtw_ieee80211.c

index cccbea555a32031476517cc5befde9236f34762b..e931afc3ba22a3372540a0b1c3ad0507402b27a6 100644 (file)
@@ -1115,8 +1115,9 @@ void rtw_macaddr_cfg(struct device *dev, u8 *mac_addr)
        }
 
        if (is_broadcast_ether_addr(mac) || is_zero_ether_addr(mac)) {
-               if ((addr = of_get_property(np, "local-mac-address", &len)) &&
-                   len == ETH_ALEN) {
+               addr = of_get_property(np, "local-mac-address", &len);
+
+               if (addr && len == ETH_ALEN) {
                        ether_addr_copy(mac_addr, addr);
                } else {
                        eth_random_addr(mac_addr);