ata: pata_cs5520: Remove unnecessary call to pci_enable_device_io()
authorHeiner Kallweit <hkallweit1@gmail.com>
Sat, 23 Mar 2024 17:14:45 +0000 (18:14 +0100)
committerBjorn Helgaas <bhelgaas@google.com>
Thu, 16 May 2024 19:35:08 +0000 (14:35 -0500)
A few lines earlier pcim_enable_device() is called, which includes the
functionality of pci_enable_device_io(). Therefore we can safely remove the
call to pci_enable_device_io().

Link: https://lore.kernel.org/r/5068d0ce-2140-4d3f-b305-e8f0d61eed1f@gmail.com
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Acked-by: Damien Le Moal <dlemoal@kernel.org>
drivers/ata/pata_cs5520.c

index 38795508c2e945cc8afddd96d3562af3c60cc931..027cf67101ef0e32e47f2a3dad8042c9b2f669ec 100644 (file)
@@ -151,12 +151,6 @@ static int cs5520_init_one(struct pci_dev *pdev, const struct pci_device_id *id)
        if (!host)
                return -ENOMEM;
 
-       /* Perform set up for DMA */
-       if (pci_enable_device_io(pdev)) {
-               dev_err(&pdev->dev, "unable to configure BAR2.\n");
-               return -ENODEV;
-       }
-
        if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32))) {
                dev_err(&pdev->dev, "unable to configure DMA mask.\n");
                return -ENODEV;