media: exynos4-is: add missing call to of_node_put()
authorYang Li <yang.lee@linux.alibaba.com>
Fri, 26 Feb 2021 01:28:40 +0000 (02:28 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 22 Mar 2021 09:14:40 +0000 (10:14 +0100)
In one of the error paths of the for_each_child_of_node() loop in
fimc_md_parse_one_endpoint, add missing call to of_node_put().

Fix the following coccicheck warning:
./drivers/media/platform/exynos4-is/media-dev.c:489:1-23: WARNING:
Function "for_each_child_of_node" should have of_node_put() before
return around line 492.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/exynos4-is/media-dev.c

index 1e5a28f32195965994bb46f1add8671f1ac6ce92..13d192ba4aa6e30f72282dec4a343887c73a0823 100644 (file)
@@ -488,8 +488,10 @@ static int fimc_md_parse_port_node(struct fimc_md *fmd,
 
        for_each_child_of_node(port, ep) {
                ret = fimc_md_parse_one_endpoint(fmd, ep);
-               if (ret < 0)
+               if (ret < 0) {
+                       of_node_put(ep);
                        return ret;
+               }
        }
 
        return 0;