staging: qlge: qlge_main.c: rewrite do-while loops into more compact for loops
authorSrivathsan Sivakumar <sri.skumar05@gmail.com>
Thu, 9 Jun 2022 20:46:39 +0000 (16:46 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 10 Jun 2022 07:02:03 +0000 (09:02 +0200)
simplify do-while loops into for loops

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Srivathsan Sivakumar <sri.skumar05@gmail.com>
Link: https://lore.kernel.org/r/YqJcLwUQorZQOrkd@Sassy
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/qlge/qlge_main.c

index 8c35d4c4b851aa3dfbe3498c7e84d4295dc4d01e..689a87d58f27c7960839351eb311a6c89992c9e7 100644 (file)
@@ -3006,13 +3006,11 @@ static int qlge_start_rx_ring(struct qlge_adapter *qdev, struct rx_ring *rx_ring
                cqicb->flags |= FLAGS_LL;       /* Load lbq values */
                tmp = (u64)rx_ring->lbq.base_dma;
                base_indirect_ptr = rx_ring->lbq.base_indirect;
-               page_entries = 0;
-               do {
-                       *base_indirect_ptr = cpu_to_le64(tmp);
-                       tmp += DB_PAGE_SIZE;
-                       base_indirect_ptr++;
-                       page_entries++;
-               } while (page_entries < MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN));
+
+               for (page_entries = 0; page_entries <
+                       MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); page_entries++)
+                               base_indirect_ptr[page_entries] =
+                                       cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE));
                cqicb->lbq_addr = cpu_to_le64(rx_ring->lbq.base_indirect_dma);
                cqicb->lbq_buf_size =
                        cpu_to_le16(QLGE_FIT16(qdev->lbq_buf_size));
@@ -3023,13 +3021,11 @@ static int qlge_start_rx_ring(struct qlge_adapter *qdev, struct rx_ring *rx_ring
                cqicb->flags |= FLAGS_LS;       /* Load sbq values */
                tmp = (u64)rx_ring->sbq.base_dma;
                base_indirect_ptr = rx_ring->sbq.base_indirect;
-               page_entries = 0;
-               do {
-                       *base_indirect_ptr = cpu_to_le64(tmp);
-                       tmp += DB_PAGE_SIZE;
-                       base_indirect_ptr++;
-                       page_entries++;
-               } while (page_entries < MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN));
+
+               for (page_entries = 0; page_entries <
+                       MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); page_entries++)
+                               base_indirect_ptr[page_entries] =
+                                       cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE));
                cqicb->sbq_addr =
                        cpu_to_le64(rx_ring->sbq.base_indirect_dma);
                cqicb->sbq_buf_size = cpu_to_le16(SMALL_BUFFER_SIZE);