net/mlx5: remove fw_fatal reporter dump option for non PF

In case function is not a Physical Function it is not allowed to collect
crdump, so if tried it will fail the fw_fatal health reporter dump
option. Instead of failing on permission, remove the option of fw_fatal
health reporter dump for such function.

Signed-off-by: Moshe Shemesh <moshe@nvidia.com>
Reviewed-by: Aya Levin <ayal@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/health.c b/drivers/net/ethernet/mellanox/mlx5/core/health.c
index 8ff6dc9bc8033e74d20c2c5423e4a87d64d05b78..721e343388dfaa895350831a1d56b79961f15bf4 100644 (file)
--- a/drivers/net/ethernet/mellanox/mlx5/core/health.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/health.c
@@ -646,12 +646,17 @@ static void mlx5_fw_fatal_reporter_err_work(struct work_struct *work)
        }
 }
 
-static const struct devlink_health_reporter_ops mlx5_fw_fatal_reporter_ops = {
+static const struct devlink_health_reporter_ops mlx5_fw_fatal_reporter_pf_ops = {
                .name = "fw_fatal",
                .recover = mlx5_fw_fatal_reporter_recover,
                .dump = mlx5_fw_fatal_reporter_dump,
 };
 
+static const struct devlink_health_reporter_ops mlx5_fw_fatal_reporter_ops = {
+               .name = "fw_fatal",
+               .recover = mlx5_fw_fatal_reporter_recover,
+};
+
 #define MLX5_FW_REPORTER_ECPF_GRACEFUL_PERIOD 180000
 #define MLX5_FW_REPORTER_PF_GRACEFUL_PERIOD 60000
 #define MLX5_FW_REPORTER_VF_GRACEFUL_PERIOD 30000
@@ -659,10 +664,12 @@ static const struct devlink_health_reporter_ops mlx5_fw_fatal_reporter_ops = {
 
 void mlx5_fw_reporters_create(struct mlx5_core_dev *dev)
 {
+       const struct devlink_health_reporter_ops *fw_fatal_ops;
        struct mlx5_core_health *health = &dev->priv.health;
        struct devlink *devlink = priv_to_devlink(dev);
        u64 grace_period;
 
+       fw_fatal_ops = &mlx5_fw_fatal_reporter_pf_ops;
        if (mlx5_core_is_ecpf(dev)) {
                grace_period = MLX5_FW_REPORTER_ECPF_GRACEFUL_PERIOD;
        } else if (mlx5_core_is_pf(dev)) {
@@ -670,6 +677,7 @@ void mlx5_fw_reporters_create(struct mlx5_core_dev *dev)
        } else {
                /* VF or SF */
                grace_period = MLX5_FW_REPORTER_DEFAULT_GRACEFUL_PERIOD;
+               fw_fatal_ops = &mlx5_fw_fatal_reporter_ops;
        }
 
        health->fw_reporter =
@@ -681,7 +689,7 @@ void mlx5_fw_reporters_create(struct mlx5_core_dev *dev)
 
        health->fw_fatal_reporter =
                devl_health_reporter_create(devlink,
-                                           &mlx5_fw_fatal_reporter_ops,
+                                           fw_fatal_ops,
                                            grace_period,
                                            dev);
        if (IS_ERR(health->fw_fatal_reporter))